1462188 - nestegg: unsigned integer overflow in [@ ne_read_int]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.webm

nestegg (test) was build unsing the following config command:
CFLAGS="-fsanitize=integer" CC=clang ./configure --enable-static --disable-shared

src/nestegg.c:758:17: runtime error: unsigned integer overflow: 41891 - 65536 cannot be represented in type 'unsigned long'
    #0 0x504898 in ne_read_int /home/user/code/nestegg/src/nestegg.c:758:17
    #1 0x504898 in ne_read_block /home/user/code/nestegg/src/nestegg.c:1444
    #2 0x4ffa97 in nestegg_read_packet /home/user/code/nestegg/src/nestegg.c:2769:11
    #3 0x4eaa88 in main /home/user/code/nestegg/test/test.c:231:10
    #4 0x7fc0f33af82f in __libc_start_main /build/glibc-Cl5G7W/glibc-2.23/csu/../csu/libc-start.c:291
    #5 0x418928 in _start (nestegg/test+0x418928)

Comment 1

[Matthew Gregan [:kinetik]]

As with bug 1462189 comment 1, this is expected (and not s-s) as we're relying on the defined modulo behaviour of unsigned types, so I think the only fix needed here if we can mark it explicitly to avoid triggering the sanitizer.

Comment 2

[Matthew Gregan [:kinetik]]

Fix will land via bug 1463586.