Closed Bug 2027946 Opened 3 months ago Closed 3 months ago

Update nestegg to new version 83efde4fc25fc72823ea84ad66c4508572f26219 from 2026-03-30 19:55:23

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: update-bot, Assigned: kinetik)

References

Details

(Whiteboard: [3pl-filed][task_id: ZvD-Fw8KQp-Fz3_Wnn9xCw])

Attachments

(1 file)

This update covers 4 commits, including 2 new upstream commits I've never filed a bug on before. (They're the top 2.). Here are the overall diff statistics, and then the commit information.


media/libnestegg/README.md | 2 -
media/libnestegg/include/nestegg/nestegg.h | 15 ++++++
media/libnestegg/moz.yaml | 4 +-
media/libnestegg/src/nestegg.c | 69 ++++++++++++++++++++++++++---
4 files changed, 79 insertions(+), 11 deletions(-)


83efde4fc25fc72823ea84ad66c4508572f26219 by Matthew Gregan <kinetik@flim.org>

https://github.com/mozilla/nestegg/commit/83efde4fc25fc72823ea84ad66c4508572f26219
Authored: 2026-03-28 10:11:42 +1300
Committed: 2026-03-31 08:55:23 +1300

Add an early frame size limit check to Xiph lacing parser.

A crafted file could trigger an unbounded number of I/O callbacks from
the Xiph lacing parser. Individual frames are already limited to
LIMIT_FRAME, but this check is enforced after lacing is parsed. Add an
early LIMIT_FRAME check to the Xiph lacing parser to enforce an upper
bound (~1M) on the number of I/O callbacks.

Files Modified:

  • src/nestegg.c

75178713c8ed16c339a830b1a57648b0a1c2d811 by Matthew Gregan <kinetik@flim.org>

https://github.com/mozilla/nestegg/commit/75178713c8ed16c339a830b1a57648b0a1c2d811
Authored: 2026-03-24 21:49:11 +1300
Committed: 2026-03-31 08:55:03 +1300

Fix a handful of UBSan warnings.

Files Modified:

  • src/nestegg.c

411cfc259a8ba613601db35900215400979f4956 by Matthew Gregan <kinetik@flim.org>

https://github.com/mozilla/nestegg/commit/411cfc259a8ba613601db35900215400979f4956
Authored: 2026-03-25 09:01:32 +1300
Committed: 2026-03-25 09:01:32 +1300

Add test for Projection subelements.

Uses demo_short.webm remuxed with ProjectionPoseRoll: -90 via mkvmerge.

Files Added:

  • test/media/projection.webm
  • test/media/projection.webm.ok

Files Modified:

  • test/regress.c
  • test/regress.test

7a53580bed1c11a63397b6f2881ef9554376c3b7 by kbinani <kbinani.bt@gmail.com>

https://github.com/mozilla/nestegg/commit/7a53580bed1c11a63397b6f2881ef9554376c3b7
Authored: 2025-09-12 09:29:12 +0900
Committed: 2026-03-25 08:54:28 +1300

Add support for Projection subelements.

Files Modified:

  • include/nestegg/nestegg.h
  • src/nestegg.c

Duplicate of this bug: 2026050
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Blocks: 1463586
Blocks: 1462194
Blocks: 1462191
Blocks: 1462189
Blocks: 1462188
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

  • test-windows11-64-24h2-asan/opt-mochitest-media-nogpu-1 - 4 of 4 failed on the same (retriggered) task (failed: JRQpoYIvQE-bTlKUax8JgQ, BAlfYeS0SGO1mfJND6rPeA, fR-y_pG6RHS2mFY-vWrblA, T8A_mr_hR4uTz8RsGrwAiw)

Needs Investigation (Possible Intermittents):

  • test-windows11-64-24h2-asan/opt-mochitest-media-1 - 4 of 4 failed on the same (retriggered) task (failed: M-tv5uUORemqc6hsRSKSjQ, QSAebXa5Q1CMyMFDvhzHIg, VDJwH4UsTWupUIQPXOeOnw, G5GprfffRuuJXSqPh9pVaQ)
  • test-windows11-64-24h2-asan/opt-mochitest-media-spi-1 - 4 of 4 failed on the same (retriggered) task (failed: CIoJfK_dTdm-bBE-Mxsbgw, Jc5dgYAZRPWH4Ah4HCUXHA, TerX3G5rSQKj5AU7ujWSaQ, du2dpB0oRzeGsphNmwW3tA)
  • test-macosx1470-64-shippable/opt-browsertime-indexeddb-firefox-addMbl1 - 1 of 4 failed on the same (retriggered) task (failed: VdAal_aKQtiEsggl3v808Q)
  • test-macosx1470-64-shippable/opt-browsertime-responsiveness-firefox-reddit-billgates-post-2 - 1 of 4 failed on the same (retriggered) task (failed: YZZSgcqiRkeC1xtkFHcARw)
  • test-macosx1470-64-shippable/opt-browsertime-tp6-firefox-expedia - 1 of 4 failed on the same (retriggered) task (failed: WPke0kQ9SwWUJtLAbJJPQQ)

Known Issues:

  • test-windows11-64-24h2-asan/opt-mochitest-media-wmfme - 2 of 4 failed on the same (retriggered) task (failed: E2Af0Sv0TOqQWm_sqUcpcg, Jz2kFFqYTp-WVs3oi3JrZA)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libnestegg/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

QA Whiteboard: [qa-triage-done-c152/b151]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: