Remove the Bookmark description UI

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Depends on 1 bug)

Trunk
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 62+, firefox62 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Per bug 1402890, we are removing the description UI for bookmarks. This bug is for removing just the front-end parts, bug 1402890 will deal with the back-end cleanup in a release later than the UI is removed.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Couple of notes:

- browser/base/content/test/general/browser_bookmark_titles.js has tests that already cover the changes I did in PlacesCommandHook.bookmarkPage in browser-places.js.
- The strings, annotations, sorting options I'll remove when we do bug 1402890.

Comment 3

a year ago
mozreview-review
Comment on attachment 8980596 [details]
Bug 1463738 - Remove the Bookmark description UI.

https://reviewboard.mozilla.org/r/246758/#review252986

LGTM except for the strings. I'm not too familiar with this code yet, so it's quite possible there's more stuff to remove that I'm not aware of. But if the UI seems to work and tests pass, I guess that's good enough for now, and we can always remove more leftovers later.

::: browser/components/places/content/editBookmarkPanel.inc.xul
(Diff revision 1)
> -
> -    <vbox id="editBMPanel_descriptionRow"
> -          collapsed="true">
> -      <observes element="additionalInfoBroadcaster" attribute="hidden"/>
> -      <label value="&editBookmarkOverlay.description.label;"
> -             accesskey="&editBookmarkOverlay.description.accesskey;"

Remove these strings and any others that become unused with this patch?
Attachment #8980596 - Flags: review?(dao+bmo)
(In reply to Mark Banner (:standard8) from comment #2)
> - The strings, annotations, sorting options I'll remove when we do bug
> 1402890.

Missed this. What's the rationale for keeping the strings?
Status: NEW → ASSIGNED
(Assignee)

Comment 5

a year ago
mozreview-review-reply
Comment on attachment 8980596 [details]
Bug 1463738 - Remove the Bookmark description UI.

https://reviewboard.mozilla.org/r/246758/#review252986

> Remove these strings and any others that become unused with this patch?

Yeah, it was a just in case, but I'd forgotten that L10n has better ways of dealing with that these days. So I'll remove them.
Comment hidden (mozreview-request)

Comment 7

a year ago
mozreview-review
Comment on attachment 8980596 [details]
Bug 1463738 - Remove the Bookmark description UI.

https://reviewboard.mozilla.org/r/246758/#review253680
Attachment #8980596 - Flags: review?(dao+bmo) → review+

Comment 8

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9a9f3abd889
Remove the Bookmark description UI. r=dao
Blocks: 1465347
(Assignee)

Comment 9

a year ago
Proposed relnote:

The description field for bookmarks has been removed. Users that manually changed the field can export old descriptions via html [1] or json [2]. Descriptions will be removed in the next release.

[1] https://support.mozilla.org/kb/export-firefox-bookmarks-to-backup-or-transfer
[2] https://support.mozilla.org/kb/restore-bookmarks-from-backup-or-move-them#w_backup-and-restore
relnote-firefox: --- → ?

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e9a9f3abd889
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
(In reply to Mark Banner (:standard8) from comment #9)
> Proposed relnote:
> 
> The description field for bookmarks has been removed. Users that manually
> changed the field can export old descriptions via html [1] or json [2].
> Descriptions will be removed in the next release.
> 
> [1]
> https://support.mozilla.org/kb/export-firefox-bookmarks-to-backup-or-transfer
> [2]
> https://support.mozilla.org/kb/restore-bookmarks-from-backup-or-move-
> them#w_backup-and-restore

Added to the release notes for Nightly 62 with this wording, I'll let the 62 release owner (CCed) decide on the inclusion and wording for beta and release
(Assignee)

Comment 12

a year ago
Pascal, please can you update the release notes to change "Descriptions will be removed in the next release" to "Stored descriptions will be removed in a future release".

(xref bug 1402890 comment 30).
Flags: needinfo?(pascalc)
(In reply to Mark Banner (:standard8) from comment #12)
> Pascal, please can you update the release notes to change "Descriptions will
> be removed in the next release" to "Stored descriptions will be removed in a
> future release".
> 
> (xref bug 1402890 comment 30).

Done
Flags: needinfo?(pascalc)
See Also: → 1469855

Updated

8 months ago
Depends on: 1493578
Comment hidden (metoo)
You need to log in before you can comment on or make changes to this bug.