1464285 - Crash in shutdownhang | NtClose via File::Close | LocalFileLoader::FontFileStream | FontFileReference

Status: NEW

(Core :: General, defect, P3)

Description

[Trevor Skywalker]

Firefox crashes while shutting down.

This bug was filed from the Socorro interface and is
report bp-61343d36-1429-451a-a6d4-7ff460180519.
=============================================================

Top 10 frames of crashing thread:

0 ntdll.dll NtClose 
1 kernelbase.dll CloseHandle 
2 dwrite.dll File::Close 
3 dwrite.dll LocalFileLoader::FontFileStream::Release 
4 dwrite.dll FontFileReference::~FontFileReference 
5 dwrite.dll FontFace::~FontFace 
6 dwrite.dll DWriteFontFace::Release 
7 xul.dll gfxDWriteFontEntry::~gfxDWriteFontEntry gfx/thebes/gfxDWriteFontList.cpp:388
8 xul.dll gfxDWriteFontEntry::`scalar deleting destructor' 
9 xul.dll gfxFontEntry::Release gfx/thebes/gfxFontEntry.h:126

=============================================================

Comment 1

[Trevor Skywalker]

Top Crasher:
#39 in Release.
#75 in Beta.
#130 in Nightly.


Top Crashers for Firefox 60.0.1
Top 50 Crashing Signatures. 7 days ago 

39 	0.3% 	-0.14% 	shutdownhang | NtClose	363 	363 	0 	0 	328 	0 	2015-01-21

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

I'm not sure if it is fair to say this is a gfx crash. Only 36 out of 843 crashes (I filtered for gfx must be in the proto signature) in the last week contain gfx in the proto signature. It seems to be spread across many components, anything that might close a handle...

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Glancing at a few reports, I don't see any reason to believe another thread is using the same handle, scanning the other thread stacks. Sometimes it is a file handle opened/closed by a Windows API as part of a single API call.

Comment 4

[Selena Deckelmann :selenamarie :selena]

Thanks for having a look. I'm going to ask :jimm to put this into a low priority research backlog. It may just be "closing a file handle is slow on some systems" issue.

Comment 5

[Wayne Mery (:wsmwk)]

Huge reduction in mid-December.  And in crashes of current versions, I am NOT finding similar stack.
For example bp-458a2a6c-eef3-4aef-99ab-86ae40181229

But there was also a huge reduction end of September
https://crash-stats.mozilla.com/signature/?signature=shutdownhang%20%7C%20NtClose&date=%3E%3D2018-06-30T22%3A10%3A47.000Z&date=%3C2018-12-30T22%3A10%3A47.000Z#graphs

Comment 6

[Trevor Skywalker]

Top Crashers for Firefox 67.0.1 (Release) - 7 days ago
#40 0.22% -0.03% shutdownhang | NtClose 184 184 0 0 178 0 2015-01-21

Signature report for shutdownhang | NtClose
Showing results from 7 days ago
714 Results

Windows 10 583 81.7%
Windows 7 55 7.7%
Windows 8.1 52 7.3%
Windows Vista 15 2.1%
Windows 8 8 1.1%
Windows XP 1 0.1%

Firefox 69.0a1 5 0.7% 6
Firefox 68.0b7 5 0.7% 6
Firefox 68.0b9 5 0.7% 6
Firefox 68.0b8 3 0.4% 3
Firefox 68.0b5 2 0.3% 2
Firefox 68.0b6 2 0.3% 2
Firefox 67.0.1 184 25.8% 247
Firefox 67.0 33 4.6% 32
Firefox 67.0.2 26 3.6% 28
Firefox 67.0b11 1 0.1% 1
Firefox 67.0b14 1 0.1% 1
Thunderbird 67.0b0 5 0.7% 3
Firefox 66.0.5 10 1.4% 8
Firefox 66.0.3 3 0.4% 3

Firefox 60.7.0esr 43 6.0% 29
Firefox 60.7.0 1 0.1% 1
Thunderbird 60.7.0 280 39.2% 324
Firefox 60.6.1esr 8 1.1% 6
Firefox 60.6.3esr 5 0.7% 6
Thunderbird 60.6.1 18 2.5% 20
Firefox 60.5.0esr 1 0.1% 1
Firefox 60.5.2esr 1 0.1% 1
Thunderbird 60.5.3 2 0.3% 2
Thunderbird 60.5.0 1 0.1% 1

Firefox 52.9.0esr 22 3.1% 19
Thunderbird 52.9.1 4 0.6% 5
Firefox 52.8.1esr 1 0.1% 1
Firefox 52.7.3esr 1 0.1% 1
Thunderbird 52.7.0 3 0.4% 2
Thunderbird 52.6.0 1 0.1% 1
Firefox 52.5.3esr 1 0.1% 1
Firefox 52.3.0esr 1 0.1% 1

Architecture
x86 424 59.4%
amd64 290 40.6%

Comment 9

[Worcester12345]

Duplicate of this bug: 1662429 was NOT during a shutdown.

Comment 10

[Andrei Purice]

Hey Trevor,
I tried reproducing this issue but couldn't. Does it still occur for you?

Comment 11

[Wayne Mery (:wsmwk)]

(In reply to Andrei Purice from comment #10)

Hey Trevor,
I tried reproducing this issue but couldn't. Does it still occur for you?

Trevor hasn't been active in over two years.

FWIW, this is no longer a topcrash in Thunderbird 91. (but it was in version 78)

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit auto_nag documentation.

Comment 13

[Marco Castelluccio [:marco]]

The volume is not concerning.