1662429 - Crash in [@ shutdownhang | NtClose] via gfxDWriteFontEntry::~gfxDWriteFontEntry()

Status: RESOLVED DUPLICATE of bug 1464285

(Thunderbird :: General, defect)

Description

78.2.1 (32-bit)

Crash report: https://crash-stats.mozilla.org/report/index/a2a5cb6c-46fd-4726-bd2b-c61590200901

Top 10 frames of crashing thread:

0 ntdll.dll NtClose 
1 kernelbase.dll CloseHandle 
2 dwrite.dll void __thiscall File::Close 
3 dwrite.dll __thiscall LocalFileLoader::FontFileStream::~FontFileStream 
4 dwrite.dll virtual unsigned long __stdcall LocalFileLoader::FontFileStream::Release 
5 dwrite.dll void __thiscall ComPtr<struct IDWriteFontFileStream>::Deref 
6 dwrite.dll __thiscall FontFileReference::~FontFileReference 
7 dwrite.dll __thiscall FontFace::~FontFace 
8 dwrite.dll virtual unsigned long __stdcall DWriteFontFace::Release 
9 xul.dll gfxDWriteFontEntry::~gfxDWriteFontEntry gfx/thebes/gfxDWriteFontList.cpp:357

0 ntdll.dll NtClose
1 kernelbase.dll CloseHandle
2 dwrite.dll void __thiscall File::Close
3 dwrite.dll __thiscall LocalFileLoader::FontFileStream::~FontFileStream
4 dwrite.dll virtual unsigned long __stdcall LocalFileLoader::FontFileStream::Release
5 dwrite.dll void __thiscall ComPtr<struct IDWriteFontFileStream>::Deref
6 dwrite.dll __thiscall FontFileReference::~FontFileReference
7 dwrite.dll __thiscall FontFace::~FontFace
8 dwrite.dll virtual unsigned long __stdcall DWriteFontFace::Release
9 xul.dll gfxDWriteFontEntry::~gfxDWriteFontEntry() gfx/thebes/gfxDWriteFontList.cpp:357
10 xul.dll gfxDWriteFontEntry::~gfxDWriteFontEntry() gfx/thebes/gfxDWriteFontList.cpp:357
11 xul.dll gfxFontFamily::~gfxFontFamily() gfx/thebes/gfxFontEntry.cpp:1835
12 xul.dll gfxDWriteFontFamily::~gfxDWriteFontFamily() gfx/thebes/gfxDWriteFontList.cpp:53
13 xul.dll static nsTHashtable<nsBaseHashtableET<nsCStringHashKey, RefPtr<gfxFontFamily> > >::s_ClearEntry(PLDHashTable*, PLDHashEntryHdr*) xpcom/ds/nsTHashtable.h:511
14 xul.dll PLDHashTable::~PLDHashTable() xpcom/ds/PLDHashTable.cpp:290
15 xul.dll gfxPlatformFontList::~gfxPlatformFontList() gfx/thebes/gfxPlatformFontList.cpp:301
16 xul.dll gfxDWriteFontList::~gfxDWriteFontList() gfx/thebes/gfxDWriteFontList.h:361
17 xul.dll static gfxPlatform::Shutdown() gfx/thebes/gfxPlatform.cpp:1262
18 xul.dll nsLayoutModuleDtor() layout/build/nsLayoutModule.cpp:267
19 xul.dll nsComponentManagerImpl::Shutdown() xpcom/components/nsComponentManager.cpp:933
20 xul.dll mozilla::ShutdownXPCOM(nsIServiceManager*) xpcom/build/XPCOMInit.cpp:735
21 xul.dll ScopedXPCOMStartup::~ScopedXPCOMStartup() toolkit/xre/nsAppRunner.cpp:1278
22 xul.dll mozilla::UniquePtr<ScopedXPCOMStartup, mozilla::DefaultDelete<ScopedXPCOMStartup> >::reset(ScopedXPCOMStartup*) mfbt/UniquePtr.h:302

Comment 1

[Wayne Mery (:wsmwk)]

Majority of 78.x crashes are via gfxDWriteFontEntry::~gfxDWriteFontEntry()
The uptick in crash rate is maybe beta 74, like bp-6835a0a9-81b7-46f8-8b96-605680200321
So maybe a result of enabling HWA - but our enabling by default didn't happen until beta 76 with bug 1623265

Comment 2

[Wayne Mery (:wsmwk)]

so this matches up to an earlier crash report of yours which we duped to bug 1464285

Comment 3

[Worcester12345]

It was NOT during any sort of shutdown, so that is incorrect.

I suggest reopening this bug until a better cause is found.

Comment 4

[Magnus Melin [:mkmelin]]

Nothing to add. The destructor is pretty empty https://searchfox.org/mozilla-central/rev/84922363f4014eae684aabc4f1d06380066494c5/gfx/thebes/gfxDWriteFontList.cpp#373 so whatever happens doesn't seem like we'll find out what's wrong.