1465825 - shlibsign crashes when compiled with cfi-icall

Status: RESOLVED WONTFIX

(NSS :: Tools, defect)

Description

[Tom Ritter [:tjr]]

> root@995b3ffd0c90:~/workspace/build/src/obj-firefox/dist/bin# LD_LIBRARY_PATH=. ./shlibsign -v -o ../../dist/firefox/libsoftokn3.chk -i ../../dist/firefox/libsoftokn3.so
> Illegal instruction

It crashes right here: https://searchfox.org/mozilla-central/rev/83a923ef7a3b95a516f240a6810c20664b1e0ac9/security/nss/cmd/shlibsign/shlibsign.c#901

> crv = (*pC_GetFunctionList)(&pFunctionList);

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

pkcs#11 meets cfi :popcorn:

Since pkcs#11 functions are by definition in a different .so you need to whitelist them, CFI only works with a single linked-together-thing.

Comment 2

[Tom Ritter [:tjr]]

Attachment: Bug 1465825 Disable cfi-icall for three of shlibsign's functions

Review commit: https://reviewboard.mozilla.org/r/248284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248284/