Closed Bug 1465967 Opened 6 years ago Closed 6 years ago

nsprpub PLHashTable not compatible with cfi-icall

Categories

(NSPR :: NSPR, defect)

Product:
NSPR
Component:
NSPR
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 2 open bugs)

Details

+++ This bug was initially created as a clone of Bug #1465825 +++ PL_NewHashTable is in nsprpub but will generally be passed function pointers in NSS. (And in a few instances, xul and nsprpub itself.) This causes icall failures. While in Bug 1465825 I started excluding sanitization from these locations, I think I'm going to switch to pursuing -fsanitize-cfi-cross-dso ...
Component: Tools → NSPR
Product: NSS → NSPR
So currently -fsanitize-cfi-cross-dso is linking against a test runtime in compiler-rt that is not production worthy. So while it 'works' for testing we wouldn't want to use it just yet. But in the future switching to it will be great. Maybe by the time we can ship CFI we can use it.
Blocks: cfi-icall
No longer blocks: 1465549
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.