1467216 - (js-docshell-tree-item) Eliminate JS consumers of the nsDocShellTreeItem APIs

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P3)

Comment 1

[Marion Daly [:mdaly]]

Thomas: Can we get details here? ready criteria/etc?

Comment 2

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 3

[Chris Peterson [:cpeterson]]

Andreas, is this bug still needed? Kannan filed a 150+ individual bugs for various uses of nsIDocShellTreeItem that need to be replaced, though the bugs look like they only cover C++ code:

https://bugzilla.mozilla.org/showdependencytree.cgi?id=1467214&hide_resolved=1

How do we detect the JS callers of nsIDocShellTreeItem?

Comment 4

[Neha Kochar [:neha]]

Kannan's list includes only the C++callers so we still need this for the JS callers. We'll need to find all users from the source tree.
Leaving farre's NI in case he has more to add here.

Comment 5

[Tim Nguyen :ntim]

Here's what I found: https://searchfox.org/mozilla-central/search?q=nsIDocShellTreeItem&case=false&regexp=false&path=js

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

In JS land, we can access interfaces related to nsIDocShellTreeItem without .QueryInterface(), thus potentially these points which accesses these members defined in idl are JS callers.

Comment 7

[Chris Peterson [:cpeterson]]

kmag generated a list of callers of JS nsIDocShellTreeItem functions:

https://gist.github.com/kmaglione/37f02aec19a182b55f94f4e32d80c984

I'll file new bugs for these callers.

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Chris Peterson [:cpeterson] from comment #7)

kmag generated a list of callers of JS nsIDocShellTreeItem functions:

https://gist.github.com/kmaglione/37f02aec19a182b55f94f4e32d80c984

I'll file new bugs for these callers.

kmag fixed many of those callers in rootTreeItem bug 1638153. He recommended I not bother filing bugs for the remaining treeOwner callers because the existing users aren't actually problematic.

As such, I will defer this bug to Fission Future until we find problems.