Open Bug 1467216 (js-docshell-tree-item) Opened 6 years ago Updated 1 year ago

Eliminate JS consumers of the nsDocShellTreeItem APIs


(Core :: DOM: Core & HTML, enhancement, P3)




Fission Milestone Future


(Reporter: relaas, Unassigned)


(Depends on 2 open bugs, Blocks 1 open bug)


      No description provided.
Thomas: Can we get details here? ready criteria/etc?
Flags: needinfo?(telin)
Priority: -- → P3
Blocks: oop-frames
Fission Milestone: --- → Future
Component: DOM → DOM: Core & HTML
Blocks: rm-docshell-tree-item
No longer blocks: oop-frames, fission
Fission Milestone: Future → M5
Priority: P3 → P2
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6

Andreas, is this bug still needed? Kannan filed a 150+ individual bugs for various uses of nsIDocShellTreeItem that need to be replaced, though the bugs look like they only cover C++ code:

How do we detect the JS callers of nsIDocShellTreeItem?

Fission Milestone: M6 → ---
Flags: needinfo?(telin) → needinfo?(afarre)

Kannan's list includes only the C++callers so we still need this for the JS callers. We'll need to find all users from the source tree.
Leaving farre's NI in case he has more to add here.

Fission Milestone: --- → M6
Priority: P2 → P3

In JS land, we can access interfaces related to nsIDocShellTreeItem without .QueryInterface(), thus potentially these points which accesses these members defined in idl are JS callers.

kmag generated a list of callers of JS nsIDocShellTreeItem functions:

I'll file new bugs for these callers.

Alias: js-docshell-tree-item
Fission Milestone: M6 → M6c
Flags: needinfo?(afarre)
Depends on: 1637785

(In reply to Chris Peterson [:cpeterson] from comment #7)

kmag generated a list of callers of JS nsIDocShellTreeItem functions:

I'll file new bugs for these callers.

kmag fixed many of those callers in rootTreeItem bug 1638153. He recommended I not bother filing bugs for the remaining treeOwner callers because the existing users aren't actually problematic.

As such, I will defer this bug to Fission Future until we find problems.

Fission Milestone: M6c → Future
Depends on: 1638153
Depends on: 1652525
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.