Closed Bug 1467872 Opened 6 years ago Closed 5 years ago

update tokio-uds crate to 0.2.0

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: gaston, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

trying to build audioipc on OpenBSD, build fails because of tokio-uds 0.1.7 not supporting OpenBSD yet:

error[E0425]: cannot find function `get_peer_cred` in module `ucred`                                 
   --> third_party/rust/tokio-uds/src/lib.rs:310:16                                                                                                                |                                                                                                                                                          310 |         ucred::get_peer_cred(self)                                                                                                                           |                ^^^^^^^^^^^^^ not found in `ucred`  

This has been fixed upstream in https://github.com/tokio-rs/tokio-uds/commit/0852f593dba403b5d9dd7fc55471fb44a1271c14 and since then all the tokio projects were merged in the tokio crate; cf https://github.com/tokio-rs/tokio

would it be possible to update this stack to 0.2.0 so that i can try enabling cubeb remoting on OpenBSD ?

i've of course tried to monkeypatch third_party/rust/tokio-uds/src/ucred.rs but the build system forbids it:

error: the listed checksum of `/usr/obj/ports/firefox-61.0beta12/firefox-61.0/third_party/rust/tokio-uds/src/ucred.rs` has changed:                           
expected: c60465ebe515eefea6de9a09e5ae67538ed28509a5c6553ef67541dca6a80bb2
actual:   33f6842a559e1f0c4f673906e93e98cfa631283108be67bcf379b4fdeec78d70

directory sources are not intended to be edited, if modifications are required then it is recommended that [replace] is used with a forked copy of the source 

if possible, i'd like to avoid diving into the cargo madness.
Blocks: 1467982
Rank: 21
Priority: -- → P3
Component: Audio/Video → Audio/Video: Playback
Summary: update tokio crate to 0.2.0 → update tokio-uds crate to 0.2.0
Upgrading to 0.2 would also upgrade the dependency of log from 0.3
to 0.4.  This bug is therefore also blocking getting rid of the
duplicate vendored 0.3.9 log crate.  (See
https://bugzilla.mozilla.org/show_bug.cgi?id=1490674.)

Done via https://github.com/djg/audioipc-2/pull/64. I'll land this in Gecko soon.

Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Depends on: 1569090
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.