1569090 - Update audioipc to 177ebd96

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task, P2)

Description

[Matthew Gregan [:kinetik]]

Update Gecko's copy of media/audioipc to 177ebd96 to pick up the following changes:

177ebd9 - client: Fix Linux build after 2018 conversion.
410db5c - Reduce duplication of IN/OUT enable/disable cases in CubebDeviceCollectionManager.
78b4c06 - Add CubebDeviceCollectionManager to handle mapping between CubebServer and shared cubeb context.
9ac51c4 - cargo fix --edition-idioms
064ac2d - Rename 'remote' to 'handle' in places we replaced a Tokio Remote with a Handle.
bd1cc2e - Update ipctest to log 0.4 to match other crates.
61d286a - Rename async.rs to async_msg.rs.
1e20923 - Sort crate imports in Cargo.toml.
6cf02bf - cargo fmt after 2018 conversion.
c4a0b6d - Update to Rust 2018 edition.
7e128ed - cargo fmt pass.
0785b90 - Address most clippy issues.
7ca93a2 - Clean up crate imports.
fcbe510 - Warn about unused crate imports.
07d25a6 - ipctest: Fix build on Windows.
ca41acd - Temporarily switch to local fork of tokio-uds's stream.rs until upstream PR 1294 is resolved.
ddc8e95 - audioipc: Add copy of tokio-uds/src/stream.rs as tokio_uds_stream.rs.
743a07c - Use kinetiknz/tokio's v0.1.x-uds branch temporarily.
96dc021 - Update Windows-specific code for Tokio 0.1.
b61cd47 - Switch from tokio_core Core to Tokio 0.1 (current_thread) Runtime.
3dad0d5 - Switch from tokio_core Handle to tokio_reactor Handle.
cad7166 - Switch to tokio-uds 0.2.5.  Requires patched tokio-uds to export clear_*_ready.
9b0e442 - client: Remove t! macro.
7c27a0f - client: Clean up error handling in client RPC setup.
a064ba6 - Remove unused core::spawn{,_fn}.
dad6bf1 - Remove unnecessary UnsafeCell from SharedMemSlice.
d6fad2c - Update to memmap 0.7.
0416e40 - Extend audioipc_server_start to accept a context name to be passed to cubeb_init.
64f3854 - Support libcubeb backend selection via new parameter to audioipc_server_start().
cb6ee87 - Move device_collection_changed handling to CubebServerCallbacks.
b864464 - Return invalid_parameter error from process_register_device_collection_changed when device type is unknown.
ca1e8c2 - Correctly handle multiple callback registration in register_device_collection_changed remoting.
aa86d0d - Clarify error reporting in ContextSetupDeviceCollectionCallback.
bc6d7d1 - Rename CubebServer.rpc to make its purpose clearer.
0198433 - Reformat ContextRegisterDeviceCollectionChanged slightly.
0fdb2a8 - Update to cubeb-rs 0.5.5.
bf55b8a - Drop unsafe lifetime hackery from ClientContext::backend_id.
21f244e - Implement remoting for cubeb_stream_register_device_changed_callback.
c20c11e - Make SHM_AREA_SIZE const common between client and server.
93acb41 - Implement remoting for cubeb_register_device_collection_changed.
984d974 - Use u8 instead of libc::uint8_t to avoid deprecation warning.
6f30ff7 - Return appropriate error from unimplemented cubeb_stream_register_device_changed_callback.
46cae18 - Implement remoting for cubeb_get_backend_id.

Vendoring this update allows us to drop the following imported crates:
log 0.3, lazycell 0.4, fs2 0.4, tokio-core 0.1

Comment 1

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f3d4ee1b56942fa8ca115ea1aee4ba612c07132

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1569090 - Update audioipc to 177ebd96. r?chunmin

Comment 3

[Matthew Gregan [:kinetik]]

Attachment: Bug 1569090 - Vendor Rust after AudioIPC update. r?chunmin

Depends on D39453

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5251efcd4ac1
Update audioipc to 177ebd96.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/6aa27e77e38f
Vendor Rust after AudioIPC update.  r=chunmin

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5251efcd4ac1
https://hg.mozilla.org/mozilla-central/rev/6aa27e77e38f

Comment 6

[Daniel Varga [:dvarga]]

Backed out 2 changesets (Bug 1569090) for causing debug SM build fail with error: failed to load source for a dependency on mio-named-pipes.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=8007ff804e997b621df8df0a63b2466cbea88621

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=258624003&repo=mozilla-central

Backout link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=258625162&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6a96fdc69cc1f05f318bb212d402142c73dd4026

[task 2019-07-27T09:41:45.726Z] + RUST_BACKTRACE=1
[task 2019-07-27T09:41:45.726Z] + export AUTOMATION=1
[task 2019-07-27T09:41:45.726Z] + AUTOMATION=1
[task 2019-07-27T09:41:45.726Z] + cargo build --verbose --frozen --features debugmozjs
[task 2019-07-27T09:41:46.148Z]     Updating git repository `https://github.com/alexcrichton/mio-named-pipes`
[task 2019-07-27T09:41:46.169Z] error: failed to load source for a dependency on `mio-named-pipes`
[task 2019-07-27T09:41:46.169Z] 
[task 2019-07-27T09:41:46.169Z] Caused by:
[task 2019-07-27T09:41:46.169Z]   Unable to update https://github.com/alexcrichton/mio-named-pipes#2072ae0d
[task 2019-07-27T09:41:46.169Z] 
[task 2019-07-27T09:41:46.169Z] Caused by:
[task 2019-07-27T09:41:46.169Z]   failed to clone into: /builds/worker/.cargo/git/db/mio-named-pipes-dfd18e26f10763c6
[task 2019-07-27T09:41:46.169Z] 
[task 2019-07-27T09:41:46.169Z] Caused by:
[task 2019-07-27T09:41:46.169Z]   attempting to update a git repository, but --frozen was specified
[taskcluster 2019-07-27 09:41:46.501Z] === Task Finished ===
[taskcluster 2019-07-27 09:41:46.601Z] Artifact "public/build" not found at "/builds/worker/artifacts/"
[taskcluster 2019-07-27 09:41:47.002Z] Unsuccessful task run with exit code: 101 completed in 229.702 seconds

Comment 7

[Matthew Gregan [:kinetik]]

My .cargo/config.in source replacements did not exactly match the Cargo.toml deps, fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a2ac36fcc85c09a1b9906d48bde9c11fb09794a&selectedJob=258644306

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02be264b5d05
Update audioipc to 177ebd96.  r=chunmin
https://hg.mozilla.org/integration/autoland/rev/bc2fd0d9da25
Vendor Rust after AudioIPC update.  r=chunmin

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/02be264b5d05
https://hg.mozilla.org/mozilla-central/rev/bc2fd0d9da25