1456555 - Always tile blob images larger than a certain size

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

Scrolling around large svg images runs into this problem.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Based on related issues like bug 1477727 and 1448868 marking this wontfix for 62. We could still get a patch in for 63 though.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

We don't plan on uplifting anything WebRender related to 63.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

We'll probably want this so that we get decent texture upload performance

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I tried this and we get rendering errors on digitalocean and the performance actually gets worse. This needs to be debugged.

Comment 5

[Maire Reavy [:mreavy]]

We can't release this to the field, but we can let this ride to beta.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Make more tiles

Comment 7

[Aria Beingessner [:Gankra]]

Comment on attachment 9007891 [details] [diff] [review]
Make more tiles

Review of attachment 9007891 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/webrender_bindings/src/bindings.rs
@@ +1255,5 @@
>      txn.add_image(
>          image_key,
>          descriptor.into(),
>          ImageData::new_blob_image(bytes.flush_into_vec()),
> +        if descriptor.format == ImageFormat::BGRA8 { Some(256, 256) } else { None }

Some(256)

Comment 8

[Markus Stange [:mstange]]

> descriptor.format == ImageFormat::BGRA8

Is this check to exclude masks? I think that deserves a comment, maybe with a pointer to bug 1435896.

Comment 9

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #8)
> maybe with a pointer to bug 1435896.

Er oops, that bug is fixed. Huh.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Without the format check I was getting crashes. I didn't have a chance to investigate. However, I too thought tiled masks weren't implemented.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Attachment: Make more tiles (and it builds)

Comment 12

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - WebRender PR 3237 - Use u32 for tiling coordinates

MozReview-Commit-ID: D71C1DaJIeV

Comment 13

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - WebRender PR 3237 - Handle float precision issues

MozReview-Commit-ID: AfA6dfFdgsQ

Depends on D10031

Comment 14

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - Fix bugs in DrawTargetOffset. r?mstange

MozReview-Commit-ID: I4XFoTp1szZ

Depends on D10033

Comment 15

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - Support Map on multiple threads. r?rhunt

This just makes the existing hack available to all DataSourceSurface implementations by default, since we use different ones with WR.

MozReview-Commit-ID: GVR0rIx8wtD

Depends on D10036

Comment 16

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - Fix SourceSurface offset handling in DTSkia::PushLayer. r?lsalzman

This got added in bug 1429508 and then removed in bug 1451845. Tiled blobs adds tests for this, so it shouldn't break again.

MozReview-Commit-ID: 3azL7SoWlr2

Depends on D10038

Comment 17

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - Deal with clipped containers being smaller than their contents during blob building. r?Gankro

MozReview-Commit-ID: I0tc6l84NRa

Depends on D10041

Comment 18

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1456555 - Enable tiled blobs. r?Gankro

MozReview-Commit-ID: JRpQ5nVFx0r

Depends on D10043

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4261b7dc70f7
Fix bugs in DrawTargetOffset. r=mstange
https://hg.mozilla.org/integration/autoland/rev/d46e2737134f
Support Map on multiple threads. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/afb19dd18556
Fix SourceSurface offset handling in DTSkia::PushLayer. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/1f269ed43301
Deal with clipped containers being smaller than their contents during blob building. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/ca90391329b7
Enable tiled blobs. r=Gankro

Comment 20

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (Bug 1456555) for reftest failures on /reftests/svg/paint-order-03.svg.

Backout: https://hg.mozilla.org/integration/autoland/rev/1a5817b175deca1b4e2500eb74f3e3d602c8def7

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ca90391329b7c7f7481ae3b98f9082356af88ba4&selectedJob=209970111

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209970111&repo=autoland&lineNumber=21564

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4df6309a5be
Fix bugs in DrawTargetOffset. r=mstange
https://hg.mozilla.org/integration/autoland/rev/595abbb5bf3e
Support Map on multiple threads. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/6cc965ecc095
Fix SourceSurface offset handling in DTSkia::PushLayer. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/5e3b20a19162
Deal with clipped containers being smaller than their contents during blob building. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/0f2854553c21
Enable tiled blobs. r=Gankro

Comment 22

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (Bug 1456555) for reftests failuress on /reftests/svg/text/pattern-content.svg.

Backout: https://hg.mozilla.org/integration/autoland/rev/b765559ddc3a9d0b54f3665de95407799e58e317

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0f2854553c211d9046d7c4161a696cdd6386185a&selectedJob=209986221

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=209986221&repo=autoland&lineNumber=6191

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6c46594d92a
Fix bugs in DrawTargetOffset. r=mstange
https://hg.mozilla.org/integration/autoland/rev/d92ef360413c
Support Map on multiple threads. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/0fb0a03bae20
Fix SourceSurface offset handling in DTSkia::PushLayer. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/69a424edfb4d
Deal with clipped containers being smaller than their contents during blob building. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/7a308f25794f
Enable tiled blobs. r=Gankro

Comment 24

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c6c46594d92a
https://hg.mozilla.org/mozilla-central/rev/d92ef360413c
https://hg.mozilla.org/mozilla-central/rev/0fb0a03bae20
https://hg.mozilla.org/mozilla-central/rev/69a424edfb4d
https://hg.mozilla.org/mozilla-central/rev/7a308f25794f

Comment 25

[Mayank Bansal]

For posterity:

== Change summary for alert #17389 (as of Tue, 06 Nov 2018 15:40:09 GMT) ==

Regressions:

 42%  tsvgx linux64-qr opt e10s stylo     245.27 -> 347.63

Improvements:

 45%  tsvg_static windows10-64-qr opt e10s stylo       90.13 -> 49.27
 31%  tsvgr_opacity windows10-64-qr opt e10s stylo     159.57 -> 109.79
 23%  tsvgr_opacity linux64-qr opt e10s stylo          155.84 -> 120.12
  7%  tsvg_static linux64-qr opt e10s stylo            68.62 -> 64.14
  6%  tsvgx windows10-64-qr opt e10s stylo             259.88 -> 243.24

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17389