1470517 - bottom pane sometimes doesn't use all available space

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

With https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr60&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-classifiedState=unclassified&group_state=expanded&fromchange=c223777b7899293b19a83b745f4c7b7a9a59fd9f&selectedJob=184403398 and the window set at a 1/3 of the width of a 4K screen and 1/2 of its height, 40% of the bottom box are white and empty while the bug suggestions and job details on the left have to be scrolled.

Comment 1

[Ed Morley [:emorley]]

I can repro - screenshot:
https://screenshots.firefox.com/wTq1coNRC49nRtdi/treeherder.mozilla.org

This is from bug 1450022.

Apart from bug 1470509 (which I'll deploy shortly), it seems that the other bugs fall into the "annoying but not blocking" category, so I'd prefer to leave bug 1450022 deployed for now - since:
* it would require a complete rollback to the previous revision (too many merge conflicts to revert just that bug)
* otherwise we'll end up not having the rest of the long tail issues with the rewrite reported until it relands the third time (Cameron and I have pretty heavily tested it on stage each time, but there are clearly too many different workflows/states/types of job data that it's not possible to catch every edge case from that type of testing)

Cameron is back on Monday and will hopefully take a look then :-)

Comment 2

[Cameron Dawson [:camd]]

I can definitely reproduce this, too.  I was hoping to solve this by instituting react-split-panel, but am having a few complications so far.  I may try to get a quicker fix to this without the resizing if I don't make quicker progress tomorrow.

Comment 3

[Cameron Dawson [:camd]]

I'm fixing this simultaneously with Bug 1468623.  So the PR for that will fix this as well.

Comment 4

[Cameron Dawson [:camd]]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/efe5c2166d181e688c77d13cef0c7854989b49c3
Bug 1468623 - Fix resizing job details / pinboard panel (#3718)