1470709 - GeckoView uses variables from UA sheets, which are exposed to content.

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Testcase (should be blank, prints #bfbfbf on nightly fennec)

The fact that rules like[1] are loaded into content is observable, and someone could start relying on it.

Also, variables are a bit slower, but that's not quite the point.

[1]: https://searchfox.org/mozilla-central/rev/9a3f8590f807d449e790c8ba0e39eb14f41066d8/mobile/android/themes/geckoview/defines.css#6

Comment 1

[Chris Peterson [:cpeterson]]

Does this bug affect both Fennec Nightly and Focus+GeckoView Nightly? Comment 0 mentions Fennec Nightly, but the stylesheet is in a geckoview directory.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Affects both.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 65 and 66 so that these already triaged issues don't show up repeatedly in weekly regression triage. Happy to take a patch in nightly.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1470709 - Stop using CSS variables from android UA stylesheets. r=snorp

Just inline them, they're not that many.

Using CSS variables is observable from content, which is not good. It also means
that we need an @import.

For bug 1618202, I plan to move this stylesheet to the global stylesheet cache.

This is so that I can add them based on prefs, but should also have memory
improvements (the stylesheet would be shared in memory across processes, see bug
1474793).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7249f7406387
Stop using CSS variables from android UA stylesheets. r=snorp

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/7249f7406387