Closed
Bug 1471522
Opened 6 years ago
Closed 5 years ago
Inline blocklist clients initialization into Blocklist.jsm
Categories
(Toolkit :: Blocklist Implementation, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: leplatrem, Assigned: leplatrem)
References
Details
Attachments
(1 file)
The implementation of blocklist clients was started in ``services/common/``. This code was remodeled and generalized as RemoteSettings, which lead to two pieces: the generic part in ``services/settings/`` and its instantiation for blocklists remained in ``services/common/``. We would like to move the instantiation of Addons/Plugins/Gfx blocklist clients to ``./toolkit/mozapps/extensions/Blocklist.jsm``. This will mainly require some refactoring in the tests. For example, the signature verification test suite of Remote Settings is implemented using the certificates blocklist client. We also need to find a place for Certificates and Pinning which are not going to be used in ``Blocklist.jsm`` when implementing Bug 1257565. Mark do you have any suggestion?
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(mgoodwin)
Comment 1•6 years ago
|
||
(In reply to Mathieu Leplatre from comment #0) > The implementation of blocklist clients was started in ``services/common/``. > This code was remodeled and generalized as RemoteSettings, which lead to two > pieces: the generic part in ``services/settings/`` and its instantiation for > blocklists remained in ``services/common/``. > > We would like to move the instantiation of Addons/Plugins/Gfx blocklist > clients to ``./toolkit/mozapps/extensions/Blocklist.jsm``. > > This will mainly require some refactoring in the tests. For example, the > signature verification test suite of Remote Settings is implemented using > the certificates blocklist client. That's fine; let me know if I can help at all. > We also need to find a place for Certificates and Pinning which are not > going to be used in ``Blocklist.jsm`` when implementing Bug 1257565. > Mark do you have any suggestion? I'm not completely sure about what you mean - do you mean a new location for those blocklist clients, or a new place to invoke the sync?
Flags: needinfo?(mgoodwin) → needinfo?(mathieu)
Assignee | ||
Comment 2•6 years ago
|
||
> That's fine; let me know if I can help at all. Thanks! Yes I believe I would need your help to generate the signatures for some new generic/fake data instead of the current certificates records, using https://searchfox.org/mozilla-central/source/services/common/tests/unit/test_blocklist_signatures > I'm not completely sure about what you mean - do you mean a new location for those blocklist clients, or a new place to invoke the sync? I mean a new place for the instanciation of those blocklist clients. The sync is now invoked with its own dedicated timer (Bug 1458917)
Flags: needinfo?(mathieu)
Updated•6 years ago
|
Component: Blocklist Policy Requests → Blocklist Implementation
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → mathieu
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bf04bcac450c Move blocklist target app filter to Blocklist module r=Gijs
Comment 6•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•