Closed
Bug 1473064
Opened 6 years ago
Closed 6 years ago
Update harfbuzz to 1.8.3
Categories
(Core :: Graphics: Text, enhancement, P3)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
109.44 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
Overview of changes leading to 1.8.2 Tuesday, July 3, 2018 ==================================== - Fix infinite loop in Khmer shaper. - Improve hb_blob_create_from_file() for streams.
Updated•6 years ago
|
Priority: -- → P3
Whiteboard: [gfx-noted]
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4943806ce512ab4f62235aeec1a4fe1f77eadb9 This was created via the new update.sh script, which was heavily influenced (i.e. stolen from) the brotli one. I won't claim any sort of exhaustive knowledge of shell scripting and am open to any suggestions for making it run more efficiently, but at least this version gets the job done from what I can tell :).
Assignee: nobody → ryanvm
Attachment #8990539 -
Flags: review?(jfkthame)
Comment 2•6 years ago
|
||
Hmm.... we really should refresh the generated files that are present in the release but are not necessarily up-to-date (ugh); see https://github.com/harfbuzz/harfbuzz/pull/1090. Maybe we could add something to our build (as we don't use the standalone harfbuzz autotools build system) to take care of this. Or at least run a check as part of the update process. I'm away for a few days but will try to think about this a bit more in a week's time.
Assignee | ||
Comment 3•6 years ago
|
||
Overview of changes leading to 1.8.3 Wednesday, July 11, 2018 ==================================== - A couple of Indic / USE bug fixes. - Disable vectorization, as it was causing unaligned access bus error on certain 32bit architectures.
Summary: Update harfbuzz to 1.8.2 → Update harfbuzz to 1.8.3
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=252a15a7ffb3b526194d906f71789f3fcb2b063b The script definitely makes things go faster! :)
Attachment #8990539 -
Attachment is obsolete: true
Attachment #8990539 -
Flags: review?(jfkthame)
Attachment #8991348 -
Flags: review?(jfkthame)
Comment 5•6 years ago
|
||
Comment on attachment 8991348 [details] [diff] [review] update harfbuzz to version 1.8.3 Review of attachment 8991348 [details] [diff] [review]: ----------------------------------------------------------------- AFAICS, this should be good to go.
Attachment #8991348 -
Flags: review?(jfkthame) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/294fc3bbabc3 Update HarfBuzz to version 1.8.3. r=jfkthame
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/294fc3bbabc3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•