Closed Bug 1473064 Opened Last year Closed Last year

Update harfbuzz to 1.8.3


(Core :: Graphics: Text, enhancement, P3)




Tracking Status
firefox63 --- fixed


(Reporter: RyanVM, Assigned: RyanVM)



(Whiteboard: [gfx-noted])


(1 file, 1 obsolete file)

Overview of changes leading to 1.8.2
Tuesday, July 3, 2018
- Fix infinite loop in Khmer shaper.
- Improve hb_blob_create_from_file() for streams.
Priority: -- → P3
Whiteboard: [gfx-noted]
Attached patch update harfbuzz to version 1.8.2 (obsolete) — Splinter Review

This was created via the new script, which was heavily influenced (i.e. stolen from) the brotli one. I won't claim any sort of exhaustive knowledge of shell scripting and am open to any suggestions for making it run more efficiently, but at least this version gets the job done from what I can tell :).
Assignee: nobody → ryanvm
Attachment #8990539 - Flags: review?(jfkthame)
Hmm.... we really should refresh the generated files that are present in the release but are not necessarily up-to-date (ugh); see

Maybe we could add something to our build (as we don't use the standalone harfbuzz autotools build system) to take care of this. Or at least run a check as part of the update process.

I'm away for a few days but will try to think about this a bit more in a week's time.
Overview of changes leading to 1.8.3
Wednesday, July 11, 2018
- A couple of Indic / USE bug fixes.
- Disable vectorization, as it was causing unaligned access bus error on
certain 32bit architectures.
Summary: Update harfbuzz to 1.8.2 → Update harfbuzz to 1.8.3

The script definitely makes things go faster! :)
Attachment #8990539 - Attachment is obsolete: true
Attachment #8990539 - Flags: review?(jfkthame)
Attachment #8991348 - Flags: review?(jfkthame)
Comment on attachment 8991348 [details] [diff] [review]
update harfbuzz to version 1.8.3

Review of attachment 8991348 [details] [diff] [review]:

AFAICS, this should be good to go.
Attachment #8991348 - Flags: review?(jfkthame) → review+
Pushed by
Update HarfBuzz to version 1.8.3. r=jfkthame
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1476334
You need to log in before you can comment on or make changes to this bug.