1475060 - Remove files under build/

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Files under build/ were used when C-C wasn't top source directory. We needed to keep them in sync with M-C.

Now the only file that is still used is mozconfig.sccache:
https://dxr.mozilla.org/comm-central/search?q=mozconfig.sccache
which is referenced in the configs.

We should check whether other files are still used and remove everything that isn't used any more.

FRG, any objections? Are these files still used in SM?

Comment 1

[Frank-Rainer Grahl (:frg)]

> FRG, any objections? Are these files still used in SM?

The builders are still running with comm-central as top but this is broken anyway and even if it builds the release is only good for a doorstopper.

Locally all is good with moz as topsource and becuase of this I don't think anyting in build is still used.

ewong is setting up the new infra but this need to take moz as top starting with esr60 into account.

ewong any objections? I think if we need additional config files we could them in suite/config as we do now.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: Test patch to remove build files in comm-esr60

Did just rip out everything I think can go in esr60 and locally all is still peachy. SeaMonkey did built fine under Windows. This was with all files from the TB comm-beta repo branch applied.

Would need some followup bugs to remove the topsrcdir logic in the make files.

Comment 3

[Frank-Rainer Grahl (:frg)]

Our comm-central configs where never adapted to mozilla as topsrcdir so pending some confirmation from ewong I would just rip out everything not needed for TB. If we need something only for SM we can put it into suite\config\mozconfigs and if it turns out that there is something needed for all comm- we can put it back in \build. Not sure if \config can also go. 

We will still use a buildbot based config in the future so there probably will be config differences for automation.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8991617 [details] [diff] [review]
Test patch to remove build files in comm-esr60

That won't work. You need mozconfig.sccache and virtualenv_packages.txt. See next comment.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1475060-remove-build-files.patch

r=tomprince via IRC.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9a0f86053b5cd90988570a8fb2ba286a06f41f1c

Added a comment to mozconfig.sccache and left virtualenv_packages.txt alone.

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, Bs jobs on Windows failed, sadly without any log, this needs more investigation.

Comment 7

[Edmund Wong (:ewong)]

(In reply to Frank-Rainer Grahl (:frg) from comment #1)
> > FRG, any objections? Are these files still used in SM?
> 
> The builders are still running with comm-central as top but this is broken
> anyway and even if it builds the release is only good for a doorstopper.
> 
> Locally all is good with moz as topsource and becuase of this I don't think
> anyting in build is still used.
> 
> ewong is setting up the new infra but this need to take moz as top starting
> with esr60 into account.
> 
> ewong any objections? I think if we need additional config files we could
> them in suite/config as we do now.

I'm fine with moving the necessary files into suite/config.

Comment 8

[Jorg K (CEST = GMT+2)]

I repeated the try run, but the "Bs" job still fails:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=248009a657f9e1531fa2b366903d37cb4cc069c3

The log (accessible via the artefacts) is this:
https://taskcluster-artifacts.net/aiIauT9wTS2-W83LxX1TqQ/0/public/logs/chain_of_trust.log
At the end we have:
2018-07-13T13:22:27    ERROR - signing:parent GEF2t39zQjSCHteMOaBPIg: the rebuilt definition doesn't match the runtime task!

Comparing to a good log:
https://taskcluster-artifacts.net/Lr6R9dwRTc-RLGWizKjUFQ/0/public/logs/chain_of_trust.log
which says:
2018-07-13T12:33:05     INFO - signing:parent: Good.

It's not clear which removal of a file in build/ caused this.

Tom, can you please advise.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dbb76057d5fa
remove most files under build/ since they are no longer used. r=tomprince

Comment 10

[Tom Prince [:tomprince]]

Bug 1475598 covers the failure above.

Comment 11

[Tom Prince [:tomprince]]

:frg, Given the above, do you have any objections to removing the support in mozilla-central's build system that supports building with comm-central outside of m-c?

Comment 12

[Frank-Rainer Grahl (:frg)]

> comm-central outside of m-c?

You mean with comm-central as topsourcedir?

Then no. This is already broken with ESR60+. Our new builders will need to switch to mozilla-central as topsource and include comm-central as comm.