1475343 - Stop using document.width and document.height

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Brian Grinstead [:bgrins]]

These APIs are being removed in Bug 1475305. As per https://developer.mozilla.org/en-US/docs/Web/API/Document/width you can use clientWidth / clientHeight instead - I've migrated m-c consumers to use `document.documentElement.clientWidth` / `document.documentElement.clientHeight`.

https://searchfox.org/comm-central/search?q=document.height&path=
https://searchfox.org/comm-central/search?q=document.width&path=

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up, Brian. Could you please CC me in the future.

There are only three uses and bug 1475305 is already on autoland.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1475343-doc-width-height.patch

Less than two hours to review this ;-)

Comment 3

[:aceman]

Comment on attachment 8991803 [details] [diff] [review]
1475343-doc-width-height.patch

Review of attachment 8991803 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Did you intentionally skip /suite? Maybe we could do this type of change for them.

Comment 4

[Jorg K (CEST = GMT+2)]

Skip? What did I miss? |browser.imageDocument.height <= sz|? That's something else, no? Hard to tell and impossible to test.

Comment 5

[:aceman]

Yes, probably that one. Bz mentioned it in bug 1475305 comment 2.
You may want to investigate what .imageDocument returns. If it is a xul document again, than you need to change it.
I'm not sure, it is at https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/browser.xml#250 .

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aff6a6f04df9
Port bug 1475305: Replace use of document.width and document.height. r=aceman

Comment 7

[Jorg K (CEST = GMT+2)]

I'll leave this to the SM folks. We will have enough bustage in bug 1470371 which which we foolishly ignored :-(

Comment 8

[Frank-Rainer Grahl (:frg)]

Thanks Jorg for the heads up. Put it on the SeaMonkey comm-central to do list.