Closed Bug 1475343 Opened Last year Closed Last year

Stop using document.width and document.height

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: bgrins, Assigned: jorgk-bmo)

References

Details

Attachments

(1 file)

These APIs are being removed in Bug 1475305. As per https://developer.mozilla.org/en-US/docs/Web/API/Document/width you can use clientWidth / clientHeight instead - I've migrated m-c consumers to use `document.documentElement.clientWidth` / `document.documentElement.clientHeight`.

https://searchfox.org/comm-central/search?q=document.height&path=
https://searchfox.org/comm-central/search?q=document.width&path=
Thanks for the heads-up, Brian. Could you please CC me in the future.

There are only three uses and bug 1475305 is already on autoland.
Less than two hours to review this ;-)
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8991803 - Flags: review?(philipp)
Attachment #8991803 - Flags: review?(acelists)
Comment on attachment 8991803 [details] [diff] [review]
1475343-doc-width-height.patch

Review of attachment 8991803 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Did you intentionally skip /suite? Maybe we could do this type of change for them.
Attachment #8991803 - Flags: review?(acelists) → review+
Skip? What did I miss? |browser.imageDocument.height <= sz|? That's something else, no? Hard to tell and impossible to test.
Yes, probably that one. Bz mentioned it in bug 1475305 comment 2.
You may want to investigate what .imageDocument returns. If it is a xul document again, than you need to change it.
I'm not sure, it is at https://dxr.mozilla.org/comm-central/source/mozilla/toolkit/content/widgets/browser.xml#250 .
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/aff6a6f04df9
Port bug 1475305: Replace use of document.width and document.height. r=aceman
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
I'll leave this to the SM folks. We will have enough bustage in bug 1470371 which which we foolishly ignored :-(
Flags: needinfo?(frgrahl)
Target Milestone: --- → Thunderbird 63.0
Version: unspecified → Trunk
Thanks Jorg for the heads up. Put it on the SeaMonkey comm-central to do list.
Flags: needinfo?(frgrahl)
Attachment #8991803 - Flags: review?(philipp) → review+
You need to log in before you can comment on or make changes to this bug.