Closed Bug 1475524 Opened 3 years ago Closed 3 years ago

Port bug 1433037 [taskbar preview's favicon appears blank] to SeaMonkey

Categories

(SeaMonkey :: OS Integration, defect)

SeaMonkey 2.56 Branch
defect
Not set
normal

Tracking

(seamonkey2.53 unaffected, seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.53 --- unaffected
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

Simple fix. Call to imgTools.decodeImage in WindowsPreviewPerTab.jsm needs to be replaced with imgTools.decodeImageAsync.

+++ This bug was initially created as a clone of Bug #1433037 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180122192913

Steps to reproduce:

Enable "Show tab previews in the Windows taskbar" feature, and move your cursor to taskbar.


Actual results:

All favicons of multitabs appear blank, not only built-in pages.
not much of a bug
Attachment #8991888 - Flags: review?(iann_bugzilla)
Attachment #8991888 - Flags: approval-comm-esr60?
Comment on attachment 8991888 [details] [diff] [review]
1475524-decodeimage.patch

Shouldn't we be looking at porting Bug 1420223 - createImageBitmap must work with nsIAsyncInputStream - part 4 - ImageBitmap must use imgITools::decodeImageBuffer (https://hg.mozilla.org/mozilla-central/diff/e60f002f07d0/browser/modules/WindowsPreviewPerTab.jsm)?
Flags: needinfo?(frgrahl)
Attachment #8991888 - Flags: review?(iann_bugzilla)
Attachment #8991888 - Flags: review+
Attachment #8991888 - Flags: approval-comm-esr60?
Attachment #8991888 - Flags: approval-comm-esr60+
> Shouldn't we be looking at porting

Yes just stumbled over this one and it was an easy fix. There are probably others missing too. We need to look at the Fx patch queues for at least feeds and shell before we can even think about releasing 2.57.
Flags: needinfo?(frgrahl)
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/cb825b099ebe
Port Bug 1433037 [taskbar preview's favicon appears blank]. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.