1475524 - Port bug 1433037 [taskbar preview's favicon appears blank] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: OS Integration, defect)

Description

[Frank-Rainer Grahl (:frg)]

Simple fix. Call to imgTools.decodeImage in WindowsPreviewPerTab.jsm needs to be replaced with imgTools.decodeImageAsync.

+++ This bug was initially created as a clone of Bug #1433037 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180122192913

Steps to reproduce:

Enable "Show tab previews in the Windows taskbar" feature, and move your cursor to taskbar.


Actual results:

All favicons of multitabs appear blank, not only built-in pages.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1475524-decodeimage.patch

not much of a bug

Comment 2

[Ian Neal]

Comment on attachment 8991888 [details] [diff] [review]
1475524-decodeimage.patch

Shouldn't we be looking at porting Bug 1420223 - createImageBitmap must work with nsIAsyncInputStream - part 4 - ImageBitmap must use imgITools::decodeImageBuffer (https://hg.mozilla.org/mozilla-central/diff/e60f002f07d0/browser/modules/WindowsPreviewPerTab.jsm)?

Comment 3

[Frank-Rainer Grahl (:frg)]

> Shouldn't we be looking at porting

Yes just stumbled over this one and it was an easy fix. There are probably others missing too. We need to look at the Fx patch queues for at least feeds and shell before we can even think about releasing 2.57.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb825b099ebe
Port Bug 1433037 [taskbar preview's favicon appears blank]. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/aacb6afd0d324c116ec00a32d174a8123d6dfbab