1790695 - Really port bug 1433037 [taskbar preview's favicon appears blank] to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: OS Integration, defect)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1475524 +++

Not so simple fix. Call to imgTools.decodeImage in WindowsPreviewPerTab.jsm needs to be replaced with imgTools.decodeImageAsync and the callback used/called when the image data has been decoded. My previous fix only renamed the function. Wonder if I tested it but probably not because 2.56 and up was broken at the time... Verfied broken in current working 2.57 too.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1790695-decodeimageasync-25315.patch

Thought about moving the duplicate code setting the defaut icon into a function but given that it matches the Fx code and is pretty much only a few lines apart so won't be overlooked if changed again didn't. But can do.

[Approval Request Comment]
Regression caused by (bug #): Bug 1433037
User impact if declined: no individual taskbar icons
Testing completed (on m-c, etc.): 2.53.15b1 pre
Risk to taking this patch (and alternatives if risky): basically the Firefox patch
String changes made by this patch: --

Comment 2

[Ian Neal]

Comment on attachment 9294501 [details] [diff] [review]
1790695-decodeimageasync-25315.patch

[Triage Comment]
Looks like the correct thing to do r/a=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1c3a6d5a0263
Call Imagelibs decodeImageAsyncWindows using a callback. r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/9261ac168743351bae4e4216c9be6aa7d21e4ceb
Call Imagelibs decodeImageAsyncWindows using a callback. r=IanN a=IanN