Build libaom on win32
Categories
(Core :: Audio/Video: Playback, defect, P2)
Tracking
()
People
(Reporter: dminor, Assigned: glandium)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Updated•6 years ago
|
Comment 1•6 years ago
|
||
Reporter | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Reporter | ||
Comment 5•6 years ago
|
||
Is it possible to enable it either (a) specifically disable it in the MSVC build configs (and then enable it generally) or (b) enable it conditionally based on the compiler so that we can ship AV1 on win32 builds?
Assignee | ||
Comment 7•6 years ago
|
||
Both are possible and I was about to write that we should do b) when I came here again and saw your comment.
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Backed out changeset b5ac6baec29b (Bug 1475564) for test_can_play_type_mpeg.html failures
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-media&revision=b5ac6baec29b55e5270c7c2abc9ddc446907144b
Backout link: https://hg.mozilla.org/integration/autoland/rev/68941a0829dc729a979b25061c258ae51859a5a4
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224907435&repo=autoland&lineNumber=1212
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=224907489&repo=autoland&lineNumber=1722
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs=vp9='probably'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | VP9 in MP4 should be supported in MSE
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="vp9"='probably'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | VP9 in MP4 should be supported in MSE
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="vp9.0"='probably'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | VP9 in MP4 should be supported in MSE
06:35:40 INFO - Buffered messages finished
06:35:40 INFO - TEST-UNEXPECTED-FAIL | dom/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="av1"='' - got "probably", expected ""
06:35:40 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:320:5
06:35:40 INFO - check@dom/media/test/test_can_play_type_mpeg.html:25:5
06:35:40 INFO - check_mp4@dom/media/test/test_can_play_type_mpeg.html:104:5
06:35:40 INFO - @dom/media/test/test_can_play_type_mpeg.html:161:1
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | audio/mpeg='maybe'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | audio/mp3='maybe'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | audio/mpeg; codecs="mp3"='probably'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | audio/mpeg; codecs=mp3='probably'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | audio/mp3; codecs="mp3"='probably'
06:35:40 INFO - TEST-PASS | dom/media/test/test_can_play_type_mpeg.html | audio/mp3; codecs=mp3='probably'
06:35:40 INFO - GECKO(1452) | MEMORY STAT | vsize 570MB | vsizeMaxContiguous 941MB | residentFast 112MB | heapAllocated 13MB
06:35:40 INFO - TEST-OK | dom/media/test/test_can_play_type_mpeg.html | took 172ms
Comment 11•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 12•6 years ago
|
||
bugherder |
Assignee | ||
Comment 13•6 years ago
|
||
Comment on attachment 9040007 [details]
Bug 1475564 - Enable libav1 when not building with msvc.
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
We shipped AV1 enabled to Windows users, except it was not built in on 32-bits Windows since bug 1445683.
Is this code covered by automated tests?
Yes
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Medium
Why is the change risky/not risky? (and alternatives if risky)
The code hasn't been build or tested in Windows 32-bits for more than 6 months, and since then we've changed compilers multiple times. OTOH, the feature is also about playing a specific kind of media that is not very widespread yet.
String changes made/needed
N/A
Comment 14•6 years ago
|
||
Comment on attachment 9040007 [details]
Bug 1475564 - Enable libav1 when not building with msvc.
OK in nightly, let's uplift to beta.
Sounds like the risk is low as there isn't a lot of media in this format yet.
Updated•6 years ago
|
Comment 15•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 16•6 years ago
|
||
I think we can let this ride the 66 train. We might want to add a relnote item for this too since we updated the Fx65 relnotes to say 64-bit only.
Assignee | ||
Comment 18•6 years ago
|
||
"Enabled AV1 support on 32-bits Windows"? Nils, what do you think?
Comment 20•6 years ago
|
||
Hi folks, I'm just a regular Firefox user. Seeing that this change might get a mention in the release notes, I wonder if macOS AV1 playback would get a mention in release notes as well?
I noticed that AV1 (media.av1.enabled) is enabled by default in Firefox 66 on macOS, from bug 1521181.
Comment 21•6 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #18)
"Enabled AV1 support on 32-bits Windows"? Nils, what do you think?
With my "Nils hat" on, this lgtm. Thanks, glandium!
Comment 22•6 years ago
|
||
Noted for 66 as: Enabled AV1 support on 32-bits Windows and MacOS -- with a link to https://research.mozilla.org/av1-media-codecs/.
Updated•4 years ago
|
Description
•