Closed Bug 1477259 Opened 2 years ago Closed 2 years ago
Fennec: aarch64 and x86 APKs share the same version code
46 bytes, text/x-phabricator-request
|Details | Review|
In bug 1477177, Sylvestre discovered he can't upload the aarch64 APK because 2 APKs can't have the same version code. This blocks bug 1368484. The choice of making aarch64 share the same code as x86 was made in bug 1360291 comment 3. The behavior is implemented at . :jchen, do you think we should revisit this behavior?  https://searchfox.org/mozilla-central/rev/8384a6519437f5eefbe522196f9ddf5c8b1d3fb4/python/mozbuild/mozbuild/android_version_code.py#128
Yeah there's an unused 'p' bit that we can turn into a "64-bit" flag.
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Use the unused 'p' bit in the version code to denote 64-bit builds, so we have different version codes for 64-bit builds on aarch64 and x86-64.
Comment on attachment 9003898 [details] Bug 1477259 - Use separate version codes for 64-bit builds; r?nalexander Nick Alexander :nalexander [he/him] has approved the revision.
Attachment #9003898 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/79c83e9cc254 Use separate version codes for 64-bit builds; r=nalexander
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 63 → mozilla63
You need to log in before you can comment on or make changes to this bug.