1477259 - Fennec: aarch64 and x86 APKs share the same version code

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

In bug 1477177, Sylvestre discovered he can't upload the aarch64 APK because 2 APKs can't have the same version code. This blocks bug 1368484. The choice of making aarch64 share the same code as x86 was made in bug 1360291 comment 3. The behavior is implemented at [1].

:jchen, do you think we should revisit this behavior?

[1] https://searchfox.org/mozilla-central/rev/8384a6519437f5eefbe522196f9ddf5c8b1d3fb4/python/mozbuild/mozbuild/android_version_code.py#128

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah there's an unused 'p' bit that we can turn into a "64-bit" flag.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1477259 - Use separate version codes for 64-bit builds; r?nalexander

Use the unused 'p' bit in the version code to denote 64-bit builds, so
we have different version codes for 64-bit builds on aarch64 and x86-64.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 9003898 [details]
Bug 1477259 - Use separate version codes for 64-bit builds; r?nalexander

Nick Alexander :nalexander [he/him] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c83e9cc254
Use separate version codes for 64-bit builds; r=nalexander

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/79c83e9cc254