Closed Bug 1477259 Opened Last year Closed Last year

Fennec: aarch64 and x86 APKs share the same version code

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jlorenzo, Assigned: jchen)

References

Details

Attachments

(1 file)

In bug 1477177, Sylvestre discovered he can't upload the aarch64 APK because 2 APKs can't have the same version code. This blocks bug 1368484. The choice of making aarch64 share the same code as x86 was made in bug 1360291 comment 3. The behavior is implemented at [1].

:jchen, do you think we should revisit this behavior?

[1] https://searchfox.org/mozilla-central/rev/8384a6519437f5eefbe522196f9ddf5c8b1d3fb4/python/mozbuild/mozbuild/android_version_code.py#128
Flags: needinfo?(nchen)
Yeah there's an unused 'p' bit that we can turn into a "64-bit" flag.
Flags: needinfo?(nchen)
Assignee: nobody → nchen
Blocks: 1480834
Status: NEW → ASSIGNED
Use the unused 'p' bit in the version code to denote 64-bit builds, so
we have different version codes for 64-bit builds on aarch64 and x86-64.
Comment on attachment 9003898 [details]
Bug 1477259 - Use separate version codes for 64-bit builds; r?nalexander

Nick Alexander :nalexander [he/him] has approved the revision.
Attachment #9003898 - Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/79c83e9cc254
Use separate version codes for 64-bit builds; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/79c83e9cc254
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Blocks: 1540152
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 63 → mozilla63
You need to log in before you can comment on or make changes to this bug.