Closed Bug 1477930 Opened Last year Closed Last year

Remove HasTags

Categories

(Toolkit :: Places, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mak, Assigned: mak)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

The hastags API is only used by the history result to decide whether to show the expander glyph close to the Tags entry in the Library.
We may not be able to get a synchronous tags status in the future, we could maybe have a delayed cache through a trigger on the new tags table. Anyway, for now we can't do much more than removing this and accepting the glyph may be lying to the user; it will show the Tags section as open-able, but won't show children when opened.
The only alternative would be to make it actually open the container, check for children and close it, but that would execute a synchronous query that'd be pointless work for most of the users.
Blocks: 1477934
Assignee: nobody → mak77
Status: NEW → ASSIGNED
The tagging API is moving to the bookmarking API, this is part of it.
This will break the tags root open glyph in the Library, for now we don't have
an alternative, we'll re-evaluate in the future in bug 1477934.
Comment on attachment 8994501 [details]
Bug 1477930 - Remove taggingService HasTags synchronous API. r=standard8

Mark Banner (:standard8) has approved the revision.

https://phabricator.services.mozilla.com/D2318
Attachment #8994501 - Flags: review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/285d7793a541
Remove taggingService HasTags synchronous API. r=Standard8
https://hg.mozilla.org/mozilla-central/rev/285d7793a541
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.