1478219 - Clean up localized region.properties (search default, search order)

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, enhancement)

Description

[Francesco Lodolo [:flod]]

1) Bug 1352539 landed in 62 and removed the default engine (browser.search.defaultenginename)

2) Bug 1461345 landed in 62 and removed search order (browser.search.order.*)

3) Bug 1477670 is likely going to land in 63, and removes Feed handlers (browser.contentHandlers.types.*). So far only for desktop, which might be quite confusing.

1) and 2) are already covered in our internal documentation, 3) should be added when it lands. Also need to double check my search data scraper scripts.

Comment 1

[Francesco Lodolo [:flod]]

Timeline: 1) and 2) can be fixed after Sep 5, when 62 moves to release. Worth waiting a few days in case we need to pick up an update for any locales.

Comment 2

[Francesco Lodolo [:flod]]

We also need to clean up l10n.toml files at this point, removing references for search.order

Looks 1) can only be done for desktop, mobile still has it. But we updated our documentation removing the default also for mobile, and I'm pretty sure I've done it for a reason.
https://github.com/mozilla-l10n/documentation/pull/134

@mike
What's the status of mobile and browser.search.defaultenginename?
https://bugzilla.mozilla.org/show_bug.cgi?id=1461347#c1

Key is still there on mobile
https://searchfox.org/mozilla-central/rev/1410bb760a5e77236b74999807f5500bd285a57d/mobile/locales/en-US/chrome/region.properties#6

But I have the feeling that shouldn't be.

Comment 3

[Mike Kaply [:mkaply]]

It can be removed. We had left it until I figured out searchorder.json (which I did).

All that should be removed is the references in the properties files. The other places in code are needed for distros.

Comment 4

[Francesco Lodolo [:flod]]

Moved feed handlers in bug 1499321

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Bug 1478219 - Remove search default and search order from l10n checks (mobile, desktop)

Comment 6

[Francesco Lodolo [:flod]]

l10n repos have been cleaned up, e.g. https://hg.mozilla.org/l10n-central/de/rev/e43b3450bbaa

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f0249190e74
Remove search default and search order from l10n checks (mobile, desktop) r=Pike

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0f0249190e74