1478578 - Previous value of task-tree filtergroup aren't restored from xulstore.json at load time

Status: RESOLVED FIXED

(Calendar :: Tasks, defect)

Description

[[:MakeMyDay]]

In the task view, the lefthand-side widget to determine the applied view filter doesn't restore the previous value at application load time form xulstore.json - it sticks with |throughcurrent| aka |Current tasks|.

Changes at runtime are persisted poperly when leaving the task view and restored accordingly after switching back to the task view tab.

Works in ESR 60b10, but fails in Lightnign 6.5. Since this is an load time only issue, it's probably a race condition related to the wx changes (n.b.: the patch for bug 1477958 doesn't resolve the issue).

Comment 1

[Geoff Lankow (:darktrojan)]

What about the patch for bug 1477956?

Comment 2

[[:MakeMyDay]]

Applying this alone or this and that from bug 1477958 doesn't change anything. Setting is still not restored.

Comment 3

[Geoff Lankow (:darktrojan)]

Gah! The mere act of adding a radiogroup to the DOM resets its value. This is going to be an ugly fix.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1478578-radiogroup-persist-1.diff

Looks like we're back to restoring (some) attributes before the overlaid elements are added to the document.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8995453 [details] [diff] [review]
1478578-radiogroup-persist-1.diff

Review of attachment 8995453 [details] [diff] [review]:
-----------------------------------------------------------------

Looking at all the work we've been putting into the overlay loader, I kind of wish we could immediately stop doing so and still get extension authors ready for WX. </rant>

Comment 6

[Jorg K (CEST = GMT+2)]

Patch doesn't apply.

Comment 7

[Geoff Lankow (:darktrojan)]

Oh yeah, still needs bug 1477956.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: 1478578-radiogroup-persist-2.diff

Same change, different place. There's no need for this to wait for the other patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8ba6a042837c
Restore persisted value of radiogroup early to prevent it being overwritten. r=philipp