Closed Bug 1476259 Opened 2 years ago Closed 3 months ago
Malfunctions of overlay loader [meta]
Let's start a bug to list malfunctions of the overlay loader with certain add-ons. For Lightning, I see double-up arrows, as per the attachment. ThunderHTMLedit doesn't work, nothing happens when you click the HTML tab. Geoff said: ... for some reason, the select event isn't firing when you click on them.
I see Loading chrome://messenger/content/overlayBindings.css into chrome://messenger/content/newmailalert.xul In the debug console. Why is that CSS file loaded into every XUL document?
The arrow issue is not related to the overlay loader, it's a regression of the twisty fix(es). I filed bug 1476718 for it.
Do you want to track the issues in this bug directly or better convert it into a meta bug?
Depends on: 1476803
Looks like a meta-bug would be better, no?
I'm using self-updated TB 63.0 x64 (2018-5-23) Daily now, and the included Lightning 65.a1 works fine, except for one problem: If I close and re-start TB, the Lightning icons on the menu bar have disappeared. The AddOns Manager shows it installed, though. In order to get the icons to re-appear for use of the add-on, I have to disable Lightning from TB's AddOns Manager, close TB, re-start it, and the Enable Lightning from the AddOns manager, whereupon TB says it has to re-start, and then the Lightning icons are there again. Since Lightning itself works fine now, is there a procedure I can use that will bring up TB with the Lightning menu-bar icons active? Can I help with testing this for a fix? Looks to me like TB is only partially actuating the add-on, not displaying it in the menu bar, on a fresh startup. Thank you.
Don't understand which version you're using. Daily is now 64.0a1 and there lightning buttons show up. For anything below, you may have to start with -purgecaches
I tried to convert an addon to use the XUL overlay according to the instructions at https://wiki.mozilla.org/Thunderbird/Add-ons_Guide_63 . The extension itself works, but I can't find a way to open the options page (before, I converted it to be compatible with TB 60). Is there a way to specify the options page in manifest.json if the options are still XUL-based? The manifest.json docs refer only to HTML options pages... The addon code for reference can be found here: https://github.com/peci1/more-snooze/tree/webextension .
(In reply to Martin Pecka from comment #9) > Is there a way to specify the options page in manifest.json if the options are still XUL-based? No there isn't, but there should be. Filing a bug now.
Don't know if I should report this here, but it looks like the overlay loader doesn't handle the insertafter attribute the right way. According to https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/insertafter the first attribute found should be selected to insert the new id, but the overlay loader inserts it after the last attribute found.
This should go into a new bug, but let's hear Geoff first.
The code has the comment "Not breaking here to match original behavior", which contradicts the documentation. I'm not sure what the original behaviour was, but I agree with the documentation. Please file a bug, Onno.
I think this is problem with the overlay loader. I'm trying to convert this addon (it's not mine) to 63 or above (I got it working in 60). https://addons.thunderbird.net/en-us/thunderbird/addon/use-bcc-instead/ I'm trying it with 64.0b4 (I get more errors in 63). The code is here: https://github.com/revad/use_bcc_instead_B On install I get (4 times): Error creating URI (invalid URL scheme?) Overlays.jsm:481 loadScript resource:///modules/Overlays.jsm:481:9 load resource:///modules/Overlays.jsm:197:28 load resource:///modules/Overlays.jsm:42:5 observe chrome://messenger/content/parent/ext-legacy.js:138:11
I strongly suspect it's because you aren't using the full address of scripts in your <script> tags. Please try it and file a bug blocking this one if I'm right.
Summary: Malfunctions of overlay loader → Malfunctions of overlay loader [meta]
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
You need to log in before you can comment on or make changes to this bug.