Further overlay loader improvements
Categories
(MailNews Core :: XUL Replacements, enhancement)
Tracking
(Not tracked)
People
(Reporter: darktrojan, Assigned: darktrojan)
References
Details
Attachments
(3 files, 3 obsolete files)
1.89 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
1.88 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
16.12 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Comment 9•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Assignee | ||
Comment 12•6 years ago
|
||
Assignee | ||
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
Updated•6 years ago
|
Comment 16•6 years ago
|
||
Updated•6 years ago
|
Comment 17•6 years ago
|
||
Comment 18•6 years ago
|
||
Comment 19•6 years ago
|
||
Comment 20•6 years ago
|
||
Assignee | ||
Comment 21•6 years ago
|
||
Comment 22•6 years ago
|
||
Comment 23•5 years ago
|
||
(In reply to Joachim Herb from comment #22)
(In reply to Geoff Lankow (:darktrojan) from comment #21)
Sorry Joachim, I hadn't seen your message until now. Yes it's possible your
listener is added after the event fires, so you should check for windows
where that's already happened. (Don't remove the listener, it's also
possible for it to be added before the event fires.)
@:darktrojan Thank you for your answer: Could you please point me to an
example how I can check if this event has been fired already?
Assignee | ||
Comment 24•5 years ago
|
||
It really is a bit late now, but we fixed this same problem in bug 1493034, and you could do the same thing we did.
Comment 25•5 years ago
|
||
(In reply to Geoff Lankow (:darktrojan) from comment #24)
It really is a bit late now, but we fixed this same problem in bug 1493034, and you could do the same thing we did.
Just seeing if this needs to be added here still.
Comment 26•5 years ago
|
||
(In reply to Worcester12345 from comment #25)
Just seeing if this needs to be added here still.
I am not sure, what you mean. I actually now use the flag added with this patch in bug 1493034.
headerViewElement.loaded = true;
https://hg.mozilla.org/comm-central/rev/e1b29b3607c4#l2.12
(by the way: is comm-central on https://dxr.mozilla.org/comm-central/ not updated?)
Now I have no idea, if other load events need such a flag also.
Description
•