Closed Bug 1478667 Opened Last year Closed Last year

Implement OS key-store adapter for macOS

Categories

(Core :: Security: PSM, enhancement, P1)

Unspecified
macOS
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: franziskus, Assigned: keeler)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

Implement an adapter to store and retrieve secrets from the keychain.
OS: Unspecified → Mac OS X
Summary: Implement OS key-store adapter for maxOS → Implement OS key-store adapter for macOS
Assignee: nobody → dkeeler
Priority: -- → P1
Whiteboard: [psm-assigned]
This implements support for OS-backed storage of secrets using the OS X keychain
APIs.
Comment on attachment 8995681 [details]
bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

(just to make sure you saw this)
Attachment #8995681 - Flags: review?(franziskuskiefer)
Attachment #8995681 - Flags: review?(spohl.mozilla.bugs)
Comment on attachment 8995681 [details]
bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

Franziskus Kiefer [:fkiefer or :franziskus] has approved the revision.

https://phabricator.services.mozilla.com/D2487
Attachment #8995681 - Flags: review+
Attachment #8995681 - Flags: review?(franziskuskiefer)
Comment on attachment 8995681 [details]
bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

Stephen A Pohl [:spohl] has approved the revision.

https://phabricator.services.mozilla.com/D2487
Attachment #8995681 - Flags: review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4bc5e9fd5a1c
implement OS key-store adapter for OS X r=franziskus,spohl
https://hg.mozilla.org/mozilla-central/rev/4bc5e9fd5a1c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Attachment #8995681 - Flags: review?(spohl.mozilla.bugs) → review+
A question came up if Firefox will now throw up a "Do you want to allow Firefox access to your keystore" dialog. Is this the case, or will this not be shown because the secrets are private to Firefox?
Flags: needinfo?(dkeeler)
I think it will only prompt if we lock the keychain (which is optional). I know right now it doesn't prompt because otherwise the test wouldn't work.
Flags: needinfo?(dkeeler)
You need to log in before you can comment on or make changes to this bug.