1478667 - Implement OS key-store adapter for macOS

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Franziskus Kiefer [:franziskus]]

Implement an adapter to store and retrieve secrets from the keychain.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

This implements support for OS-backed storage of secrets using the OS X keychain
APIs.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8995681 [details]
bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

(just to make sure you saw this)

Comment 3

[Phabricator Automation]

Comment on attachment 8995681 [details]
bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

Franziskus Kiefer [:fkiefer or :franziskus] has approved the revision.

https://phabricator.services.mozilla.com/D2487

Comment 4

[Phabricator Automation]

Comment on attachment 8995681 [details]
bug 1478667 - implement OS key-store adapter for OS X r?franziskus,spohl

Stephen A Pohl [:spohl] has approved the revision.

https://phabricator.services.mozilla.com/D2487

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bc5e9fd5a1c
implement OS key-store adapter for OS X r=franziskus,spohl

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4bc5e9fd5a1c

Comment 7

[Stephen A Pohl [:spohl]]

A question came up if Firefox will now throw up a "Do you want to allow Firefox access to your keystore" dialog. Is this the case, or will this not be shown because the secrets are private to Firefox?

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I think it will only prompt if we lock the keychain (which is optional). I know right now it doesn't prompt because otherwise the test wouldn't work.