Closed Bug 1478970 Opened Last year Closed Last year

Can't update Nightly from about:firefox or notification bar - Android O+

Categories

(Firefox for Android :: General, defect, major)

Firefox 63
ARM
Android
defect
Not set
major

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified

People

(Reporter: oana.horvath, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: --do_not_change--[priority:high])

Attachments

(1 file)

Device: Android 8 and higher
Build: Nightly 63.0a1 (2018-07-27);

Steps to reproduce:
Same thing as Bug 1476900, but the fix doesn't work on Android O & P devices.

Expected result:
Nightly should install the update.

Actual result:
Can't update Nightly from about:firefox.
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
Whiteboard: [priority:high]
Whiteboard: [priority:high] → --do_not_change--[priority:high]
Attachment #8995986 - Flags: review?(sdaswani) → review?(nchen)
Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

https://reviewboard.mozilla.org/r/260266/#review267414

We don't want this permission for all builds, just the builds that use our updater (so builds that use Google Play should not have this permission). Is there a flag that we can use to check that?
Attachment #8995986 - Flags: review?(nchen) → review-
Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

https://reviewboard.mozilla.org/r/260266/#review267414

As per https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#2243
I think MOZ_UPDATER is the flag we need.
Attachment #8995986 - Flags: review?(sdaswani)
Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

https://reviewboard.mozilla.org/r/260266/#review267600

::: mobile/android/base/FennecManifest_permissions.xml.in:39
(Diff revision 2)
>      <uses-feature android:name="android.hardware.touchscreen"/>
>  
>      <!-- Tab Queue -->
>      <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
>  
> +    <!-- To be able to install Nightly app updates on API 26+ -->

Nit: move comment to inside `#ifdef`
Attachment #8995986 - Flags: review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/7a4290ed6a61
Can't update Nightly from about:firefox or notification bar - Android O+; r=jchen
Keywords: checkin-needed
Attachment #8995986 - Flags: review?(sdaswani)
Wouldn't we require the same permission in order to generically launch APKs the user has downloaded?
See Also: → 1480079
https://hg.mozilla.org/mozilla-central/rev/7a4290ed6a61
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Flags: qe-verify+
Verified as fixed on Nightly 63 (2018-08-02).
Huawei Honor 8 (Android 7.0)
Google Pixel (Android P Beta)
HTC 10 (Android 8.0)
Mi 4i (Android 5.0.2)
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.