1478970 - Can't update Nightly from about:firefox or notification bar - Android O+

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oana Horvath [:ohorvath]]

Device: Android 8 and higher
Build: Nightly 63.0a1 (2018-07-27);

Steps to reproduce:
Same thing as Bug 1476900, but the fix doesn't work on Android O & P devices.

Expected result:
Nightly should install the update.

Actual result:
Can't update Nightly from about:firefox.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

As per
https://android-developers.googleblog.com/2017/08/making-it-safer-to-get-apps-on-android-o.html
and
https://developer.android.com/reference/android/Manifest.permission.html#REQUEST_INSTALL_PACKAGES
after targeting API 26 we need a new permission to be able to install Apks.

Review commit: https://reviewboard.mozilla.org/r/260266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260266/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

https://reviewboard.mozilla.org/r/260266/#review267414

We don't want this permission for all builds, just the builds that use our updater (so builds that use Google Play should not have this permission). Is there a flag that we can use to check that?

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

https://reviewboard.mozilla.org/r/260266/#review267414

As per https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#2243
I think MOZ_UPDATER is the flag we need.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260266/diff/1-2/

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

https://reviewboard.mozilla.org/r/260266/#review267600

::: mobile/android/base/FennecManifest_permissions.xml.in:39
(Diff revision 2)
>      <uses-feature android:name="android.hardware.touchscreen"/>
>  
>      <!-- Tab Queue -->
>      <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
>  
> +    <!-- To be able to install Nightly app updates on API 26+ -->

Nit: move comment to inside `#ifdef`

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8995986 [details]
Bug 1478970 - Can't update Nightly from about:firefox or notification bar - Android O+;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/260266/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a4290ed6a61
Can't update Nightly from about:firefox or notification bar - Android O+; r=jchen

Comment 8

[Jan Henning [:JanH]]

Wouldn't we require the same permission in order to generically launch APKs the user has downloaded?

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7a4290ed6a61

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 63 (2018-08-02).
Huawei Honor 8 (Android 7.0)
Google Pixel (Android P Beta)
HTC 10 (Android 8.0)
Mi 4i (Android 5.0.2)