1479021 - Add support for URL-based parameters in provider endpoint

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Kate Hudson :k88hudson]

The legacy snippets implementation allows for the replacement of several values according to release channel, version, locale, and several others via the browser.aboutHomeSnippets.updateUrl pref:

https://snippets.allizom.org/%STARTPAGE_VERSION%/%NAME%/%VERSION%/%APPBUILDID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/

We should allow for this in provider endpoints as well in ASR since snippets will continue to support this.

Comment 1

[Kate Hudson :k88hudson]

Are all of these parameters in the URL still used/needed by the snippets service or only some?

Comment 2

[Giorgos Logiotatidis [:giorgos]]

(In reply to Kate Hudson :k88hudson from comment #1)
> Are all of these parameters in the URL still used/needed by the snippets
> service or only some?

Used always:
 - startpage
 - locale
 - channel


Other fields that have been used:
 - Name
 - Version
 - AppbuildID
 - OS Version

What's the reasoning behind changing what we have?

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4284

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/0427d3aa62fc98b4eb0315aa642258984c7c5d22
Bug 1479021: support url params in provider endpoints (#4284)

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9