1479478 - Exclude default search URLs from topsites

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

Basic proposal is that it doesn't make sense to put default search URLs in top sites.

We should exclude URLs that match the default search engine.

We can use ParseSubmissionURL to determine this.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4278

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/20e90a85575c044f529e03d22e51c0c37a6251db
Bug 1479478 - Exclude default search URLs from topsites

https://github.com/mozilla/activity-stream/commit/092e1c74ae4dc2599e6a2e519c8ef9e61f17c80e
Merge pull request #4278 from k88hudson/bug1479478

Bug 1479478 - Exclude default search URLs from topsites

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4287

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e7779578da1e1d88c019709fc87f1dbb6eb3cd9c
Bug 1479478 - Support alexa top 5 search for top sites filtering
Also turns on the search filter experiment be default

https://github.com/mozilla/activity-stream/commit/6a130ecb234bb46f449cbaf33522aed55dbcc621
Merge pull request #4287 from k88hudson/bug1479478b

Bug 1479478 - Support alexa top 5 search for top sites filtering

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f99759ea7410

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the default search engines are excluded from the "Top Sites" area using the following steps:

1. I've installed an older version of "Firefox Nightly" (from 07/30/2018).
2. Populated the "Top Sites" area with different search engines (eg. "Google", "Yahoo" "Duckduckgo").
3. Updated the browser to the latest version.

After the update the search engines, that were displayed in the "Top Sites" area, were excluded and replaced by the new default ones such as "Google" and Amazon.

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 8

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is not reproducible in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64. The targeted pre-existing Top Sites are correctly converted to search shortcuts (Google) or no longer displayed (Duckduckgo, Bing).