1480042 - Request queue dropdown badge shows empty names for some display names

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Screenshot

We have a contributor who is just known by his nickname, and he uses [:MakeMyDay] as his bugzilla display name so the commonly used :nickname completion works.

The review queue popup in the top bar makes it say "asked you for review...", without any name. If the real name is empty, I'd suggest to either parse out the nickname from the first [:nickname], or just fall back to displaying the whole thing.

Comment 1

[Kohei Yoshino]

We have an obvious inconsistency in how people’s names are displayed, but given that Bugzilla is introducing nick names (Bug 1476288), it’s better to use them everywhere, just like GitHub. The modal bug page is already displaying nick names in some parts, or their email address’ name part as a fallback. So in this case, [:MakeMyDay] will be simply MakeMyDay. PR coming shortly.

Comment 2

[Kohei Yoshino]

The new nickname extracts:

fetch('https://bugzilla.mozilla.org/request.cgi?action=queue&requestee=philipp%40bugzilla.kewis.ch&group=requestee&ctype=json')
  .then(response => response.json())
  .then(requests => requests.map(req => {
    const [, name, email] = req.requester.match(/^(?:(.*)\s<)?(.+?)>?$/);
    const nickname = ((name || '').match(/\:(.+?)\b/) || [])[1] || email.split('@')[0];
    return nickname;
  }))
  .then(nicknames => console.dir(nicknames));

Comment 3

[Kohei Yoshino]

Attachment: pull request

Comment 5

[Kohei Yoshino]

Merged to master.