1480130 - Shadow DOM interferes with Cmd+click on wpt staging site

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE (on Mac, but using Ctrl+click on Windows/Linux has the same behavior, I am told):

1)  Use nightly, make sure the "dom.webcomponents.shadowdom.enabled" pref is true.
2)  Load https://staging.wpt.fyi/results/
3)  Cmd+click on the  "2dcontext/" link.

EXPECTED RESULTS: New tab opens with https://staging.wpt.fyi/results/2dcontext

ACTUAL RESULTS: Nothing happens.

If I flip "dom.webcomponents.shadowdom.enabled" to false, things work.  So presumably shadow DOM messes with the event getting to the browser chrome somehow?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Per https://github.com/web-platform-tests/wpt.fyi/issues/193 middle-click has the same issue, for probably the same reason.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

e10s and non-e10s use almost exactly the same code
https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/browser/base/content/browser.js#5910
https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/browser/modules/ClickEventHandler.jsm#125

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: click_in_shadow_dom.diff

We're lacking tests in general here, but this modified existing test which works in both e10s and non-e10s mode.


remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/72e1899f3617e368ce8dd4be16236aeb23055024
remote:   https://hg.mozilla.org/try/rev/a626bbb30a71238ba0eb3ca42cb9ec2322c2c85b
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=a626bbb30a71238ba0eb3ca42cb9ec2322c2c85b
remote: recorded changegroup in replication log in 0.006s

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbc754cfd3ce
Shadow DOM interferes with Cmd+click handling, r=felipe

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fbc754cfd3ce