1480212 - Preemptively fix unified bustage in layout/generic

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Daniel Holbert [:dholbert]]

(see earlier versions of this bug -- e.g. bug 1300206, bug 1344954)

The directory layout/generic doesn't quite build right now if I disable unification (by doing s/UNIFIED_SOURCES/SOURCES/ in its moz.build file)

I get several copies of this build error for calls to NS_NewXULElement in nsCanvasFrame.cpp:

> layout/generic/nsCanvasFrame.cpp:142:10: error: use of
>   undeclared identifier 'NS_NewXULElement'; did you mean 'NS_NewXMLDocument'?
>     rv = NS_NewXULElement(getter_AddRefs(mPopupgroupContent),
          ^~~~~~~~~~~~~~~~

This is easy to fix - just need to add an include for nsContentCreatorFunctions.h, to provide the declaration of this function:
https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/dom/base/nsContentCreatorFunctions.h#63

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1480212: Give nsCanvasFrame.cpp an #include to provide NS_NewXULElement decl, to fix non-unified builds in layout/generic. r?emilio

Comment 2

[Phabricator Automation]

Comment on attachment 8996843 [details]
Bug 1480212: Give nsCanvasFrame.cpp an #include to provide NS_NewXULElement decl, to fix non-unified builds in layout/generic. r?emilio

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

https://phabricator.services.mozilla.com/D2627

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c66ba2794d94
Give nsCanvasFrame.cpp an #include to provide NS_NewXULElement decl, to fix non-unified builds in layout/generic. r=TYLin

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c66ba2794d94