Closed Bug 1480472 Opened Last year Closed Last year

Replace “Close Tabs to the Right and “Close Other Tabs” with Close Tab Options Sub-Menu

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

63 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 64
Tracking Status
firefox63 --- wontfix
firefox64 --- verified

People

(Reporter: amylee, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Replace “Close Tabs to the Right and “Close Other Tabs” with Close Tab Options Sub-Menu when one tab is selected. Please see spec for reference.
Priority: -- → P3
No longer blocks: tabs-multiselect
No longer blocks: 1494755
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2a709a740cf
Replace 'Close Tabs to the Right' and 'Close Other Tabs' with 'Close Tab Options' submenu. r=Felipe
https://hg.mozilla.org/mozilla-central/rev/b2a709a740cf
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Verified in latest Nightly.
Build ID 	20181003100127
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Is there some background as to why this change was made? As far as I see, it makes two common context menu actions now take an extra click/wait. Sorry if this is the wrong place to voice this concern.
Flags: needinfo?(amlee)
(In reply to Dragory from comment #5)
> Is there some background as to why this change was made? As far as I see, it
> makes two common context menu actions now take an extra click/wait. Sorry if
> this is the wrong place to voice this concern.

Hi, 

The change was made to introduce new actions into the context menu (i.e move tab) while not increasing the number of menu items in the context menu by moving less utilized actions into a sub menu. This is part of a larger series of changes to reorganize and update the context menu to accommodate multi-select tabs. Unfortunately, there will be trade-offs but the hope is that these new functions would be beneficial to the user.
Flags: needinfo?(amlee)
If this is going to be moved into a submenu, I think "Close Tabs to Left" should be added too. Otherwise as a user I hate this change and would rather just be able to customize context menus myself if the number of options is too big.
I understand the change was made to introduce new options while not increasing the size of the menu, but IMHO it will be better to have "close other tabs" in the parent menu and maybe "close tab" in the new submenu. 

The reason I am suggesting this is because "close other tabs" is a frequently used action in that menu, while "close tab" is not. If I want to close the tab I will just click on X besides the tab title or just cmd+w/ctrl+w which is an standard shortcut for all tabbed interfaces in the OS.
I use both "close tabs to the right" and "close other tabs" options all the time (it's the only reason I ever use that context menu). But I do understand why this change was made, and why a lot of people might not be using these so often.

Would it be possible to add a setting somewhere to change this behaviour? Like `about:config`? Is there some other place for tiny config options like this? If so, I'd be very happy to try implementing that change, but maybe someone could guide me a little bit towards the right direction?
>I use both "close tabs to the right" and "close other tabs" options all the time
>it's the only reason I ever use that context menu
I, too!

Autors,
Why didn't you hide the menu items "select all tabs" or "add tab to bookmarks"? Or "send to your device"? Who even selects all the tabs and sends them to the device??

Why were the _most frequently used points_ chosen for hiding? to prove that you wanted to spit on the users, and they would swallow it?
Please, add an option (or about:config preference) to revert this behaviour. Many users prefer longer menus with less clicks and less mouse movement (less prone to misclicks).

There's a userChrome tweak around but it's kind of buggy.
Depends on: 1502083
Verified the changes with 64.0b8 on Win10, macOS10.13, Ubuntu16.04.

On the current nightly builds, are the changes reverted?
Status: RESOLVED → VERIFIED
Flags: needinfo?(amlee)
(In reply to Cristi Fogel [:cfogel] from comment #12)
> Verified the changes with 64.0b8 on Win10, macOS10.13, Ubuntu16.04.
> 
> On the current nightly builds, are the changes reverted?

Yes, they are reverted and this patch will be reverted on Beta soon enough. See bug 1502083.
Flags: needinfo?(amlee)
Awesome, thank you for the info!
I'm very happy to hear that this has been reverted. Another major usability issue this caused for me, which I haven't seen anyone else mention, is that the when the menu is is open it obscures the "undo close tab" option which is *right under it* and also very frequently used. I have accidentally moused over the submenu and selected one of the "close tabs" options countless times, which would have been disastrous if I didn't have the confirmation dialog enabled. It has been very frustrating.
You need to log in before you can comment on or make changes to this bug.