1502083 - Close other tabs buried in a menu

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[Sawyer Blatz [:sblatz]]

Attachment: Screen Shot 2018-10-25 at 10.34.11 AM.png

The "close other tabs" button is now buried in a "close tab options" sub-menu, which makes it really slow to use (notably "bookmark tab" and "duplicate tab" are in the initial menu which I have never used). I use this button probably 10-15 times a day, so the time spent waiting for this sub-menu to open up really adds up. I also have to fight muscle memory I have from years of it being in the initial drop down. Can we consider reverting this change?

Comment 1

[Dão Gottwald [:dao]]

Jared, can you please evaluate / prioritize this / run it by UX? Thanks.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Amy, this change was requested for multiselect tabs. I think we should reconsider this. What are your thoughts?

Comment 3

[Amy Lee [:amylee] UX]

Hi, 

I will look into telemetry data for the context menu to see where we can better reorg under utilized functions. In the meantime you can move the close tab functions out of the sub menu.

Comment 4

[Marion Daly [:mdaly]]

(In reply to Amy Lee [:amylee] UX from comment #3)
> Hi, 
> 
> I will look into telemetry data for the context menu to see where we can
> better reorg under utilized functions. In the meantime you can move the
> close tab functions out of the sub menu.

Amy: Did we get the telemetry data for this?

Comment 5

[Amy Lee [:amylee] UX]

(In reply to Marion Daly [:mdaly] from comment #4)
> (In reply to Amy Lee [:amylee] UX from comment #3)
> > Hi, 
> > 
> > I will look into telemetry data for the context menu to see where we can
> > better reorg under utilized functions. In the meantime you can move the
> > close tab functions out of the sub menu.
> 
> Amy: Did we get the telemetry data for this?

Hi, 

I asked and we don't have telemetry for this. I made a recommendation that we should.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1502083 - Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r?dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/170fbadab0f5
Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r=dao

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/170fbadab0f5

Comment 9

[Dão Gottwald [:dao]]

[Tracking Requested - why for this release]: We changed course and shouldn't let bug 1480472 slip into just one release.

Comment 10

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance, thanks!

Comment 11

[37313]

Amy Lee [:amylee] UX
Thank you for your adequacy! In a variety of topics, we tried to convey to the developers the undesirability of this change. And once you have decided everything, thank you. :)

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9023413 [details]
Bug 1502083 - Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r?dao

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1480472

User impact if declined: Users may have trouble finding the "Close Tabs to the Right" and "Close Other Tabs" menuitems and it will take them longer to use them when they have found them.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This patch just moves some XUL around to remove the submenu and put these items back in the main tab context menu.

String changes made/needed: none

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9023413 [details]
Bug 1502083 - Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r?dao

move close tabs options back out of a submenu, so we don't ship the change in 64 and immediately revert it in 65; approved for 64.0b10.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #12)
> String changes made/needed: none

This patch has a string removal in it. NI Flod to approve landing this on Beta. Or I'd assume we could just drop that change from the uplift and let that removal ride in 65.

Comment 15

[Francesco Lodolo [:flod]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)
> This patch has a string removal in it. NI Flod to approve landing this on
> Beta. Or I'd assume we could just drop that change from the uplift and let
> that removal ride in 65.

The latter (a patch that doesn't touch the DTD file) would work definitely better for me.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03052d0f2f71

Comment 17

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 65.0a1 (2018-10-25) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly! But the bug stills remains with Bets 64.0b9-20181112164519(Close other tabs buried in 'close tab options' menu)

Build ID 	20181115223444
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Comment 18

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox  65.0a1 (2018.10.25) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b10 and 65.0a1 on Win 10 x64, Ubuntu 18.04 x64 and Mac OS X 10.13.6.

Comment 19

[gershonido]

It seems that the submenu "Close Multiple Tabs" is back in the Developer Edition version 78.0b2 (64-bit). Was this done on purpose?

Comment 20

[Francesco Lodolo [:flod]]

(In reply to gershonido from comment #19)

It seems that the submenu "Close Multiple Tabs" is back in the Developer Edition version 78.0b2 (64-bit). Was this done on purpose?

Bug 887515 moved them back in a submenu, see last comments there for the rationale.

Comment 21

[Daniel]

They've closed comments in the other thread, so I don't how hoe to indicate my great irritation at this change. Should I create a defect? Is there a tracking issue somewhere I can vote for? This is a case of the devs getting very out of touch, this change is completely ridiculous especially when you consider that there's a reopen closed tab shortcut for those few that rarely accidentally click this option.

Comment 22

[gershonido]

Yes - they have deleted quite a few comments from the thread of the new change (https://bugzilla.mozilla.org/show_bug.cgi?id=887515) and then closed it for further comments. This is probably because A LOT of people complained about the annoying sub-menu. Not very professional - just block comments rather than deal with the problem.

Comment 23

[Murz]

I use right-click menu most times exactly for "Close Tabs to the Right" and now must always use submenu - this is bad UX! Please give back "Close Tabs to the Right" at first level of menu, or provide option to configure this "feature"!

Comment 24

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Daniel from comment #21)

They've closed comments in the other thread, so I don't how hoe to indicate my great irritation at this change. Should I create a defect? Is there a tracking issue somewhere I can vote for? This is a case of the devs getting very out of touch, this change is completely ridiculous especially when you consider that there's a reopen closed tab shortcut for those few that rarely accidentally click this option.

Thanks for the feedback. I have seen the feedback and I know that the solution we implemented isn't perfect but we also had to balance it with people losing their data accidentally and not wanting to put up modal dialogs everywhere. We will continue to think of ways to make this better while trying to balance all of those concerns.

Comment 25

[Maxim]

Status:
VERIFIED FIXED
Milestone:
Firefox 65

Not sure what exactly is fixed?
Do you have any plans to remove sub-menu? It is very annoying and not useful.
Can it be at least configurable in about:config?

Comment 26

[Maxim]

(In reply to Marion Daly [:mdaly] from comment #4)

(In reply to Amy Lee [:amylee] UX from comment #3)

Hi,

I will look into telemetry data for the context menu to see where we can
better reorg under utilized functions. In the meantime you can move the
close tab functions out of the sub menu.

Amy: Did we get the telemetry data for this?

"Data collected with telemetry shows us that 100% of our users use telemetry."