Close other tabs buried in a menu

VERIFIED FIXED in Firefox 64

Status

()

defect
P1
normal
VERIFIED FIXED
6 months ago
5 months ago

People

(Reporter: sblatz, Assigned: jaws)

Tracking

(Blocks 1 bug, {regression})

unspecified
Firefox 65
Desktop
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox63 unaffected, firefox64+ verified, firefox65 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 months ago
The "close other tabs" button is now buried in a "close tab options" sub-menu, which makes it really slow to use (notably "bookmark tab" and "duplicate tab" are in the initial menu which I have never used). I use this button probably 10-15 times a day, so the time spent waiting for this sub-menu to open up really adds up. I also have to fight muscle memory I have from years of it being in the initial drop down. Can we consider reverting this change?
Blocks: 1480472
Jared, can you please evaluate / prioritize this / run it by UX? Thanks.
Flags: needinfo?(jaws)
Keywords: regression
OS: Mac OS X → All
Amy, this change was requested for multiselect tabs. I think we should reconsider this. What are your thoughts?
Flags: needinfo?(jaws) → needinfo?(amlee)
Hi, 

I will look into telemetry data for the context menu to see where we can better reorg under utilized functions. In the meantime you can move the close tab functions out of the sub menu.
Flags: needinfo?(amlee)
Blocks: 1458007
Priority: -- → P1
(In reply to Amy Lee [:amylee] UX from comment #3)
> Hi, 
> 
> I will look into telemetry data for the context menu to see where we can
> better reorg under utilized functions. In the meantime you can move the
> close tab functions out of the sub menu.

Amy: Did we get the telemetry data for this?
Flags: needinfo?(amlee)
(In reply to Marion Daly [:mdaly] from comment #4)
> (In reply to Amy Lee [:amylee] UX from comment #3)
> > Hi, 
> > 
> > I will look into telemetry data for the context menu to see where we can
> > better reorg under utilized functions. In the meantime you can move the
> > close tab functions out of the sub menu.
> 
> Amy: Did we get the telemetry data for this?

Hi, 

I asked and we don't have telemetry for this. I made a recommendation that we should.
Flags: needinfo?(amlee)

Comment 7

6 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/170fbadab0f5
Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r=dao
Assignee: nobody → jaws
Status: NEW → ASSIGNED

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/170fbadab0f5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
[Tracking Requested - why for this release]: We changed course and shouldn't let bug 1480472 slip into just one release.
Please request uplift to beta when you get a chance, thanks!

Comment 11

6 months ago
Amy Lee [:amylee] UX
Thank you for your adequacy! In a variety of topics, we tried to convey to the developers the undesirability of this change. And once you have decided everything, thank you. :)
Comment on attachment 9023413 [details]
Bug 1502083 - Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r?dao

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1480472

User impact if declined: Users may have trouble finding the "Close Tabs to the Right" and "Close Other Tabs" menuitems and it will take them longer to use them when they have found them.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This patch just moves some XUL around to remove the submenu and put these items back in the main tab context menu.

String changes made/needed: none
Attachment #9023413 - Flags: approval-mozilla-beta?
Comment on attachment 9023413 [details]
Bug 1502083 - Move the 'Close Other Tabs' and 'Close Tabs to the Right' back to the main tab context menu and out of a submenu. r?dao

move close tabs options back out of a submenu, so we don't ship the change in 64 and immediately revert it in 65; approved for 64.0b10.
Attachment #9023413 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Jared Wein [:jaws] (Regression Engineering Owner for 65) (please needinfo? me) from comment #12)
> String changes made/needed: none

This patch has a string removal in it. NI Flod to approve landing this on Beta. Or I'd assume we could just drop that change from the uplift and let that removal ride in 65.
Flags: needinfo?(francesco.lodolo)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)
> This patch has a string removal in it. NI Flod to approve landing this on
> Beta. Or I'd assume we could just drop that change from the uplift and let
> that removal ride in 65.

The latter (a patch that doesn't touch the DTD file) would work definitely better for me.
Flags: needinfo?(francesco.lodolo)
I have reproduced this bug with Nightly 65.0a1 (2018-10-25) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly! But the bug stills remains with Bets 64.0b9-20181112164519(Close other tabs buried in 'close tab options' menu)

Build ID 	20181115223444
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
QA Whiteboard: [bugday-20181114]
I have reproduced this issue using Firefox  65.0a1 (2018.10.25) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 64.0b10 and 65.0a1 on Win 10 x64, Ubuntu 18.04 x64 and Mac OS X 10.13.6.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.