Closed Bug 1481067 Opened 2 years ago Closed 2 years ago

Remove comm-topdir remnants from SeaMonkey make and builds files.

Categories

(SeaMonkey :: Build Config, enhancement)

SeaMonkey 2.57 Branch
enhancement
Not set
normal

Tracking

(seamonkey2.53 unaffected, seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.53 --- unaffected
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

References

Details

Attachments

(2 files, 2 obsolete files)

Building SeaMonkey with comm-xxx as top source dir is broken since 2.57. Bug 1479904 removed the toplevel build files. 

Until mailnews and calendar are doing this our configure.in still need to set internally from the comm/comm-confvars.sh. We can remove everything else from our suite files now.
Attached patch 1481067-moztop.patch (obsolete) — Splinter Review
Attachment #8997731 - Flags: review?(iann_bugzilla)
Attachment #8997731 - Flags: feedback?(ewong)
Attachment #8997731 - Flags: approval-comm-esr60?
Attached patch 1481067-moztop-257.patch (obsolete) — Splinter Review
The actual esr60 version
Comment on attachment 8997731 [details] [diff] [review]
1481067-moztop.patch

Review of attachment 8997731 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8997731 - Flags: feedback?(ewong) → feedback+
f+ from ewong retained. Moved a confvars.sh change to remove no longer existing fxaccounts setting into it. No other changes.
Attachment #8997731 - Attachment is obsolete: true
Attachment #8997731 - Flags: review?(iann_bugzilla)
Attachment #8997731 - Flags: approval-comm-esr60?
Attachment #8998914 - Flags: review?(iann_bugzilla)
Attachment #8998914 - Flags: feedback+
Attachment #8998914 - Flags: approval-comm-esr60?
actual esr60 version
Attachment #8997732 - Attachment is obsolete: true
Comment on attachment 8998914 [details] [diff] [review]
1481067-moztop.patch

r/a=me
I presume the changes needed in the shared code (including calendar) are in another bug?
Attachment #8998914 - Flags: review?(iann_bugzilla)
Attachment #8998914 - Flags: review+
Attachment #8998914 - Flags: approval-comm-esr60?
Attachment #8998914 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6e3b94bc5eaf
Remove option to build comm-central as topsourcedir from suite. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1490867
You need to log in before you can comment on or make changes to this bug.