1481721 - Switch Linux Nightlies and PGO builds to clang

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium] (high latency)]

Attachment: Switch Linux nightlies and PGO builds to clang

And enable LTO on CI builds using clang + PGO.

Comment 2

[Mike Hommey [:glandium] (high latency)]

Attachment: Switch Linux nightlies and PGO builds to clang

Updated to avoid busting artifact builds (and probably l10n) with "mozbuild.configure.options.InvalidOptionError: LLVM_PROFDATA is not available in this configuration" errors. Carrying over r+.

Comment 3

[Mike Hommey [:glandium] (high latency)]

Attachment: Bug 1481721 - Switch Linux nightlies and PGO builds to clang

And enable LTO on CI builds using clang + PGO.

Comment 4

[Mike Hommey [:glandium] (high latency)]

I uploaded all the old versions of the patch to phabricator, and pushed the last updates to actually fix the artifact/l10n builds problem mentioned in comment 2 and to adapt to changes from bug 1486998.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 9006406 [details]
Bug 1481721 - Switch Linux nightlies and PGO builds to clang

Nathan Froyd [:froydnj] has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23860890d959
Switch Linux nightlies and PGO builds to clang r=froydnj

Comment 8

[Bogdan Tara[:bogdan_tara]]

https://hg.mozilla.org/mozilla-central/rev/23860890d959

Comment 9

[Joel Maher ( :jmaher ) (UTC-4)]

perf improvements:
== Change summary for alert #15834 (as of Wed, 12 Sep 2018 02:54:15 GMT) ==

Improvements:

 13%  tp5o responsiveness linux64 pgo e10s stylo                0.68 -> 0.59
 13%  displaylist_mutate linux64 pgo e10s stylo                 2,122.70 -> 1,857.24
 10%  perf_reftest_singletons linux64 pgo e10s stylo            47.40 -> 42.62
  9%  speedometer linux64 pgo e10s stylo                        78.89 -> 86.14
  9%  about_preferences_basic linux64 pgo e10s stylo            154.50 -> 140.54
  8%  tp5o_webext linux64 pgo e10s stylo                        200.79 -> 185.24
  7%  a11yr linux64 pgo e10s stylo                              189.58 -> 175.45
  7%  dromaeo_dom linux64 pgo e10s stylo                        3,245.74 -> 3,471.69
  7%  ts_paint_webext linux64 pgo e10s stylo                    205.50 -> 192.08
  6%  tp5o_webext responsiveness linux64 pgo e10s stylo         1.26 -> 1.18
  6%  tsvgx linux64 pgo e10s stylo                              180.21 -> 169.47
  6%  tsvg_static linux64 pgo e10s stylo                        69.29 -> 65.21
  6%  tart linux64 pgo e10s stylo                               2.06 -> 1.95
  5%  tp5o linux64 pgo e10s stylo                               129.52 -> 122.46
  4%  tscrollx linux64 pgo e10s stylo                           0.68 -> 0.65
  4%  sessionrestore linux64 pgo e10s stylo                     336.00 -> 323.67
  4%  sessionrestore_no_auto_restore linux64 pgo e10s stylo     356.25 -> 343.50
  3%  tp5o_scroll linux64 pgo e10s stylo                        0.59 -> 0.57

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=15834

Comment 10

[Liz Henry (:lizzard)]

This is in 64 release notes as, "Improved performance for Mac and Linux users, by enabling link time optimization (Clang LTO). (Clang LTO was enabled for Windows users in Firefox 63.)" (along with enabling LTO for Mac in bug 1473786).