Closed Bug 1481916 Opened Last year Closed 13 days ago

migrate l10n bumper to treescript

Categories

(Release Engineering :: Release Automation: L10N, enhancement)

enhancement
Not set

Tracking

(firefox-esr6872+ fixed, firefox72 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr68 72+ fixed
firefox72 --- fixed

People

(Reporter: aki, Assigned: aki)

References

Details

Attachments

(5 files)

Currently, we run l10n-bumper via cron, through a puppetized mozharness workdir, on two use1 buildbot masters. These can get stuck (bug 1455355) and are less visible/testable than other automation in taskcluster. We also want to retire the buildbot masters in September. These two masters are in use1, so we don't need to retire them when scl3 goes away, but it would be preferable to not need to keep them around indefinitely.

We're currently thinking:

- migrate l10n-bumper behavior to treescript
- add the appropriate scopes to control that behavior and restrict it
- create a cron task and hook to trigger it on a schedule. The hook should be manually triggerable by releaseduty and probably ciduty; we may want to allow the l10n team to trigger it as well.

This task should ideally be visible on treeherder, so errors are more noticeable.
At some point, rather than landing directly, this task would push to phabricator and land via lando.
Assignee: nobody → aki
Attached file treescript PR

https://firefoxci.taskcluster-artifacts.net/Qy9g939aT-2YnIbh1lhdRQ/0/public/logs/live_backing.log seems to show I need to fix the purge call (or the mercurial extensions/deps).

sheehan 12:30
@aki: I haven't seen that before but I took a look and I think it's a bug in robustcheckout
purge used to import util when that line was introduced, now imports scmutil and cmdutil instead

Attachment #9108892 - Attachment description: Bug 1481916 - add l10n-bumper task. → Bug 1481916 - add l10n-bumper task. r=callek
Status: NEW → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Regressions: 1597671
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Backout by rmaries@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/4bc97ee973d2
Backed out changeset 11f48aaae955 as per aki's request. a=backout

Backed out changeset 11f48aaae955 (bug 1481916) for causing l10 bumper exceptions

Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fe3bf81d49d
Backed out changeset 11f48aaae955 for causing l10 bumper exceptions CLOSED TREE
Attachment #9108892 - Attachment description: Bug 1481916 - add l10n-bumper task. r=callek → Bug 1481916 - add l10n-bumper task. r=Callek

Tom, any thoughts?

Flags: needinfo?(mozilla)

I think if you hacked taskgraph to generate a metadata that pointed at esr68, it would test what you want.

Flags: needinfo?(mozilla)

The metadata hack didn't work: it broke CoT.

I:

  • created a PR to add source_repo and target_repo support, and populated source_repo in-tree
  • fixed the esr68 l10n dashboard link
  • removed the use of push scopes, so we can try to push to try in the future
  • fixed flake8
  • tested a bunch

I'm pretty confident in this now. Thanks for your help!

I was wondering if we would need a way to override ignore-closed-tree and force the cron hook, so mergeduty can run l10n-bumper. Then I realized that in the near future, we'll be kicking off both Firefox and Devedition b1 without a week of beta closure, so we may not need to force it (we just need to reopen beta to approval-only after merging, then wait for the l10n bumper to run before gtb).

Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98bbf5137827
add l10n-bumper task. r=Callek,tomprince
Status: REOPENED → RESOLVED
Closed: 19 days ago13 days ago
Resolution: --- → FIXED

Comment on attachment 9108892 [details]
Bug 1481916 - add l10n-bumper task. r=Callek

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This will enable the l10n bumper for Fennec releases on esr68.
  • User impact if declined: When we turn off buildbot-master01, where the retiring l10n bumper has been running, we'll no longer pick up new Fennec locale bumps. If we no longer need Fennec releases off esr68, this may be the desirable outcome.
  • Fix Landed on Version: 72
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): I've tested quite a bit on Try. We now count the number of outgoing changes and make sure they match the expected number of outgoing patches.
  • String or UUID changes made by this patch:
Attachment #9108892 - Flags: approval-mozilla-esr68?

(In reply to Aki Sasaki [:aki] (he/him) (UTC-7) from comment #20)

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This will enable the l10n bumper for Fennec releases on esr68.
  • User impact if declined: When we turn off buildbot-master01, where the retiring l10n bumper has been running, we'll no longer pick up new Fennec locale bumps. If we no longer need Fennec releases off esr68, this may be the desirable outcome.

From an l10n POV, I'd prefer to be on the safe side and continue to ship string updates on Fennec. Well, I consider this landing to the safe side than not landing it.

Worked like a charm on beta earleir today as part of mergeduty! \o/

:jcristau, do you have an opinion about whether we should keep running l10n bumper on esr68 for Fennec? We're going to shut down the instance that's running l10n bumper soon, and we'll need to uplift https://bugzilla.mozilla.org/attachment.cgi?id=9108892 to keep running l10n bumper on esr68.

Flags: needinfo?(jcristau)

Sounds like we should uplift then. I suspect the EOL for fennec on esr68 is a few months away still.

flod fyi.

Flags: needinfo?(jcristau)
Whiteboard: [checkin-needed-esr68]

Comment on attachment 9108892 [details]
Bug 1481916 - add l10n-bumper task. r=Callek

For posterity.

Attachment #9108892 - Flags: approval-mozilla-esr68? → approval-mozilla-esr68+
You need to log in before you can comment on or make changes to this bug.