1482145 - PhabBot changes are showing up as from the wrong user, and also sending email incorrectly (based on the wrong current user)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect, P1)

Description

[Dylan Hardison [:dylan] (he/him)]

11:02 <Standard8> So I’m reviewing someone’s patchset, and I’m getting bugmail notifications saying that the other person has changed the bug, even though the comment is from myself.
11:02 <Standard8> Is that bugzilla or phab?
11:02 <Standard8> i.e. where should I file the bug
11:04 <Standard8> there’s kinda two bugs here, but maybe only one: 1) I’m getting email for stuff I’m doing. 2) the email is wrong (foo changed bug xxx….. comment on bug xxx from Me!)

Comment 1

[Mark Banner (:standard8)]

Attachment: badreviewemail.eml

This is one of the unexpected emails I got.

Paolo is the person that requested the review, and I reviewed it.

So I shouldn't have received the email, but in any case, it was myself that changed the bug, not Paolo.

Comment 2

[Mark Banner (:standard8)]

Just to note, the original requester didn't get the bugmail.

Comment 3

[David Lawrence [:dkl]]

FWIW this bug 1482145 when landed should fix this issue and probably other related issues. I want to do some extensive testing first before putting it up for review.

Comment 4

[David Lawrence [:dkl]]

Attachment: github pr #709

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Attachment: Stronger parameter checking via types

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Attachment: Use Scope::Guard when changing the current user.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Attachment: Use the user that triggered the change when sending the email.

Comment 9

[Dylan Hardison [:dylan] (he/him)]

Attachment: Refactor the revision reviewers list to be a list of reviews.

Comment 10

[Dylan Hardison [:dylan] (he/him)]

Attachment: Some changes required for unit tests to be written

Comment 11

[:Gijs (he/him)]

I'm still seeing issues like this, ie this change: https://bugzilla.mozilla.org/show_bug.cgi?id=1483167#c6 got me a bugzilla email that said Drew changed the bug. Drew requested review, but I granted it, so the email is wrong, but the bug comment is correct.

Is that being fixed here, and just not deployed yet? Or should I file a new bug, and if so, is that a bugzilla bug or a phabricator bug?

Comment 12

[David Lawrence [:dkl]]

(In reply to :Gijs (he/him) from comment #11)
> I'm still seeing issues like this, ie this change:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1483167#c6 got me a bugzilla
> email that said Drew changed the bug. Drew requested review, but I granted
> it, so the email is wrong, but the bug comment is correct.
> 
> Is that being fixed here, and just not deployed yet? Or should I file a new
> bug, and if so, is that a bugzilla bug or a phabricator bug?

Yes the fix has been committed but not yet deployed. It should be going live soon.

dkl