1482404 - The new search section got a non-transparent background. Was that necessary?

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Darkspirit]

(I like the dimensions of the new search field. Nice!)

You broke my use case. ;D

https://screenshotscdn.firefoxusercontent.com/images/945c3ac1-8870-4355-afb8-7bf76585d9c6.jpg

~/.mozilla/firefox/_profilename_/chrome/userContent.css
@-moz-document url("about:newtab") {
  body { background-image: url("https://www.bing.com/az/hprichbg/rb/AuroraPhotographer_DE-DE10752129713_1920x1080.jpg") !important;
background-size: cover !important;
background-attachment: fixed !important;
  }
  .screenshot {
    opacity: 0.1 !important;
  }
}

Comment 1

[Ed Lee :Mardak]

Looks like the background was added for the persistent search bug 1481677

https://github.com/mozilla/activity-stream/pull/4298

Comment 2

[Darkspirit]

If I add some other sections and scroll down, it looks very nice.
https://screenshotscdn.firefoxusercontent.com/images/9b74c55a-8acd-48ed-9cfc-e5dc36d4ad91.jpg

(I just noticed text encoding bugs of german words (center bottom context menu + section title "Overview") and will try to narrow it down.)

Comment 3

[Darkspirit]

(Sorry, I don't know how to narrow down the text encoding bug. bug 1401649)

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Ed Lee :Mardak from comment #1)
> Looks like the background was added for the persistent search bug 1481677
> 
> https://github.com/mozilla/activity-stream/pull/4298

Oh oops. It is really only needed in the fixed position header state. I'll remove the color from the default case.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4314

Comment 6

[Darkspirit]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #2)
> I just noticed text encoding bugs

Filed bug 1482422.

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/e3e2554062b93af7a4a4b353e6f124a73b92fda4
Fix Bug 1482404 - remove unnecessary search background-color

https://github.com/mozilla/activity-stream/commit/9e0cec13fa127dd57d4cfa11856013be276c1126
Merge pull request #4314 from rlr/bug1482404/scrolling-search-bbackground

Fix Bug 1482404 - remove unnecessary search background-color

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/322c3cf43fe8

Comment 9

[Darkspirit]

Verified fixed in Nightly 63 x64 20180811103606 de_DE @ Debian Testing (KDE, Xorg, Nvidia GTX 1060). Thank you!

Comment 10

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 11

[Cristian Fogel [:cfogel]]

Verified issue for 62.0b18, over macOS10.13, Ubuntu 18.04lTS, Win10x64.
Issue does not appear anymore.