Closed Bug 1483460 Opened 7 years ago Closed 6 years ago

trim bug number and reviewer from summary when generating bugzilla attachment description

Categories

(bugzilla.mozilla.org :: Phabricator Integration, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: karlt, Unassigned)

References

Details

Not sure what is best for the review syntax. It may be useful because review requests are not mapped to bugzilla requests, but it is only useful if accurate. Bug 1483457 at least makes this misleading ATM.
it isn't clear to me exactly what you're requesting. can you provide examples of the behaviour you're seeing, and what you expect to see?
Flags: needinfo?(karlt)
This is about generating a bugzilla attachment description from the first line (summary) of a commit message. I guess that has little to do with moz-phab, sorry. For a summary "bug 1483174 use float constants with float delay time variables r?padenot", bzexport would describe the attachment as "use float constants with float delay time variables" That is the preferred description for the bugzilla attachment IMO. Mozreview would describe the attachment as (and even change the description of an existing unrelated attachment) to "bug 1483174 use float constants with float delay time variables" With moz-phab, I see "Bug 1483174 use float constants with float delay time variables r=padenot" I guess moz-phab changed the case and s/?/=/, but this bug is really about removing "bug 1483174" and "r?padenot" entirely, which I guess is the "Phabricator" component. I'm not sure.
Component: Review Wrapper → Phabricator
Flags: needinfo?(karlt)
Summary: moz-phab: trim bug number from bugzilla attachment description → trim bug number and reviewer from summary when generating bugzilla attachment description
Component: Phabricator → Extensions: PhabBugz
Product: Conduit → bugzilla.mozilla.org
Version: unspecified → Production
Having the Differential revision id somewhere in bugzilla would be useful too, to distinguish several attachments on the same bug (which sometimes all have the same commit message), and to determine which is associated with which differential revision without waiting for loads on each attachment. The attachment description may be a good place if no mozreview-like UI will be added to bugzilla.

since this bug was filed we've added a panel to bugzilla that shows the associated phabricator diffs.

as we plan on defocusing the bugzilla attachments we won't be making changes to improve their display.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
See Also: → 1528874
You need to log in before you can comment on or make changes to this bug.