Remove fallback styling from toolbarbutton.css

RESOLVED FIXED in Firefox 54

Status

()

defect
RESOLVED FIXED
2 years ago
10 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla54
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1334429 +++

See bug 1288747 comment 10 and bug 756759 for some context and reasoning.
This has already been done for Linux elsewhere (likely many years ago).
OS: All → Windows
Comment on attachment 8838484 [details]
Bug 1340495 - Remove fallback styling from toolbutton.css.

https://reviewboard.mozilla.org/r/113420/#review114888
Attachment #8838484 - Flags: review?(mak77) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/836545828524
Remove fallback styling from toolbutton.css. r=mak
Depends on: 1340626
https://hg.mozilla.org/mozilla-central/rev/836545828524
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Summary: Remove fallback styling from toolbutton.css → Remove fallback styling from toolbarbutton.css
Posted image dropmarker.png
This patch regressed the appearance of the dropmarker of toolbarbutton type="menu" in Thunderbird. Now the rule of https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/dropmarker.css#5 is used which defines border and background-color.

Can the change on .toolbarbutton-menubutton-dropmarker be reverted to make the appearance correct again?
Flags: needinfo?(dao+bmo)
I suspect this might be the same as bug 1340626. What I think we'll want to do to address this is to remove the fallback styling from dropmarker.css too.
Flags: needinfo?(dao+bmo) → needinfo?(richard.marti)
Flags: needinfo?(richard.marti)
Yes, it's bug 1340626, and removing the styling from dropmarker.css would fix this.
No longer depends on: 1340888
Blocks: 1341048
Depends on: 1341269
Blocks: 1484422
Blocks: 1492130
You need to log in before you can comment on or make changes to this bug.