1340495 - Remove fallback styling from toolbarbutton.css

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1334429 +++

See bug 1288747 comment 10 and bug 756759 for some context and reasoning.

Comment 1

[Dão Gottwald [:dao]]

This has already been done for Linux elsewhere (likely many years ago).

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1340495 - Remove fallback styling from toolbutton.css.

Review commit: https://reviewboard.mozilla.org/r/113420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113420/

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8838484 [details]
Bug 1340495 - Remove fallback styling from toolbutton.css.

https://reviewboard.mozilla.org/r/113420/#review114888

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/836545828524
Remove fallback styling from toolbutton.css. r=mak

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/836545828524

Comment 6

[Richard Marti (:Paenglab)]

Attachment: dropmarker.png

This patch regressed the appearance of the dropmarker of toolbarbutton type="menu" in Thunderbird. Now the rule of https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/dropmarker.css#5 is used which defines border and background-color.

Can the change on .toolbarbutton-menubutton-dropmarker be reverted to make the appearance correct again?

Comment 7

[Dão Gottwald [:dao]]

I suspect this might be the same as bug 1340626. What I think we'll want to do to address this is to remove the fallback styling from dropmarker.css too.

Comment 8

[Richard Marti (:Paenglab)]

Yes, it's bug 1340626, and removing the styling from dropmarker.css would fix this.