1484462 - Update webdriver to hyper 0.12

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P1)

Description

[Bastien Orivel [:eijebong]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180817100105

Comment 1

[Bastien Orivel [:eijebong]]

Attachment: Bug 1484462 Part 1 - Update webdriver to hyper 0.12. r?ato

MozReview-Commit-ID: G9aOKGHXgo

Bug 1484462 Part 2 - Revendor dependencies. r?ato

MozReview-Commit-ID: 7PFevFl7dGj

Comment 2

[Andreas Tolfsen ❲:ato❳]

jgraham: You might want to be aware of this change.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Could we please wait with this change until I'm done with the Serde conversion on bug 1396821? A patch for that bug should be up today.

Comment 4

[Bastien Orivel [:eijebong]]

Attachment: 0001-Bug-1484462-Part-1-Update-webdriver-to-hyper-0.12.-r.patch

Comment 5

[Bastien Orivel [:eijebong]]

Attachment: 0002-Bug-1484462-Part-2-Revendor-dependencies.-r-ato.patch

Comment 6

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3e8b399cf86e872ba212353e96d2d74d1165731

Comment 7

[Andreas Tolfsen ❲:ato❳]

This change causes a panic at build time for me:
https://gist.github.com/andreastt/5b314a3545879bc37a2b785b221609dc

Comment 8

[Andreas Tolfsen ❲:ato❳]

(In reply to Andreas Tolfsen ﹝:ato﹞ from comment #7)

> This change causes a panic at build time for me:
> https://gist.github.com/andreastt/5b314a3545879bc37a2b785b221609dc

OK, it seems that was the result of some bad build artefacts in the
object directory.  A clean build resolved the issue for me locally.

Comment 9

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 9003230 [details] [diff] [review]
0001-Bug-1484462-Part-1-Update-webdriver-to-hyper-0.12.-r.patch

Review of attachment 9003230 [details] [diff] [review]:
-----------------------------------------------------------------

r+ pending successful try run.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9003230 [details] [diff] [review]
0001-Bug-1484462-Part-1-Update-webdriver-to-hyper-0.12.-r.patch

Review of attachment 9003230 [details] [diff] [review]:
-----------------------------------------------------------------

::: Cargo.lock
@@ -69,4 @@
>  source = "registry+https://github.com/rust-lang/crates.io-index"
>  dependencies = [
>   "kernel32-sys 0.2.2 (registry+https://github.com/rust-lang/crates.io-index)",
> - "libc 0.2.39 (registry+https://github.com/rust-lang/crates.io-index)",

Shouldn't the changes of this file be part of the vendoring patch?

Comment 11

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #10)
> Comment on attachment 9003230 [details] [diff] [review]
> 0001-Bug-1484462-Part-1-Update-webdriver-to-hyper-0.12.-r.patch
> 
> Review of attachment 9003230 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: Cargo.lock
> @@ -69,4 @@
> >  source = "registry+https://github.com/rust-lang/crates.io-index"
> >  dependencies = [
> >   "kernel32-sys 0.2.2 (registry+https://github.com/rust-lang/crates.io-index)",
> > - "libc 0.2.39 (registry+https://github.com/rust-lang/crates.io-index)",
> 
> Shouldn't the changes of this file be part of the vendoring patch?

I prefer for them to be part of the first patch so they are possible
to review.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/738e47717e3f
Update webdriver to hyper 0.12. r=ato
https://hg.mozilla.org/integration/mozilla-inbound/rev/03df1a267ea5
Revendor Rust dependencies. r=ato

Comment 13

[Andreas Tolfsen ❲:ato❳]

I had to do some rebasing and tweaking of the patches due to
https://bugzilla.mozilla.org/show_bug.cgi?id=1484941, but try was
green so I landed them on inbound.

Thanks eijebong!

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/738e47717e3f
https://hg.mozilla.org/mozilla-central/rev/03df1a267ea5