1484867 - Replace remaining use of XPCOMUtils.generateQI() and XPCOMUtils.generateCI () in mailnews, ldap, editor

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

... since it's going to be removed in bug 1484466.

https://searchfox.org/comm-central/search?q=XPCOMUtils.generateQI&case=false&regexp=false&path=

calendar/providers/gdata/modules/calUtilsShim.jsm
editor/ui/nsComposerCmdLineHandler.js
ldap/xpcom/src/nsLDAPProtocolHandler.js
mailnews/addrbook/src/nsAbLDAPAttributeMap.js
and a heap of suite/, that is, SeaMonkey stuff.

Calendar/gData is special, editor is most likely of the composer part of SeaMonkey, so only ldap/mailnews is left.

Geoff, gData is broken again, see bug 1481180. Aceman, can you take ldap/mailnews?

Comment 1

[Jorg K (CEST = GMT+2)]

Note bug 1484466 comment #17:

> Calendar/gData is special
It still needs to be fixed. Presumably the shim should just switch to ChromeUtils.generateQI.bind(ChromeUtils).

Comment 2

[Geoff Lankow (:darktrojan)]

Is it time to just remove the shim, Philipp? We've already switched to a JSON manifest and tied the minimum Thunderbird version to the current version.

Comment 3

[Jorg K (CEST = GMT+2)]

Bug 1484466 will get merged to M-C today. I guess it doesn't matter for Calendar since the gData test is already disabled, see bug 1481180.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1484867-ldap-editor-mailnews.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53687d94637f
Replace remaining use of XPCOMUtils.generateQI() in ldap, editor, mailnews. rs=bustage-fix DONTBUILD

Comment 6

[:aceman]

Comment on attachment 9002677 [details] [diff] [review]
1484867-ldap-editor-mailnews.patch

Review of attachment 9002677 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 7

[Jorg K (CEST = GMT+2)]

I missed  XPCOMUtils.generateCI(). Let's move the mailnews/ parts from bug 1484957 to here and let's move all Calendar bits to bug 1484957.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1484957-generate-ci-1.diff

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/da8e1ef4aab4
Port bug 1484466: remove uses of XPCOMUtils.generateCI() in mailnews/. r=jorgk