Closed Bug 1485426 Opened 6 years ago Closed 6 years ago

Audit callers of document.createElement in XUL documents

Categories

(Firefox :: General, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file)

Over in bug 1485147 we ran into more createElement calls that needed to be migrated to createXULElement. I've added logging to browser chrome tests to find the rest. https://treeherder.mozilla.org/#/jobs?repo=try&revision=86cf2bae81e44783d1905ac0a7744a44232969f5
Priority: -- → P3
Depends on: 1485996
Preparing for transitioning to XHTML. MozReview-Commit-ID: JLlmUxsvhIB
For future reference to find more createElements from XUL: 1) Apply the patch https://hg.mozilla.org/try/rev/e15fbc016dfdb0da4862f0a7415154bfa338c023 2) use try fuzzy with "instrumentation" 3) Download all logs in folder 4) To get a list of all the unique callers run cat *.log | grep "CreateElement called" | sed -E 's/.*\|/LOG/g' | sort | uniq > caller.txt or to get filenames only: cat *.log | grep "CreateElement called" | sed -E 's/.*\|/LOG/g' | sed -E 's/.*"(.*)".*/\1/g' | sort | uniq > file_only.txt The above commands could be simplified, but it was built as I went.
Comment on attachment 9003918 [details] Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins Brian Grinstead [:bgrins] has approved the revision.
Attachment #9003918 - Flags: review+
Pushed by bdahl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3bc799b58c46 Use createXULElement instead of createElement in XUL docs. r=bgrins
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Depends on: 1486220
Depends on: 1486237
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: