Closed Bug 1485533 Opened 6 years ago Closed 5 years ago

NSS_SSL_TESTS on taskcluster

Tracking

(Not tracked)

Status:

RESOLVED FIXED

Milestone:

3.46

People

(Reporter: mt, Assigned: kjacobs)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1485533 - Close gaps in taskcluster SSL testing. r?mt 5 years ago Kevin Jacobs [:kjacobs] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1485533 - Close gaps in taskcluster SSL testing. r?mt 5 years ago Kevin Jacobs [:kjacobs] 47 bytes, text/x-phabricator-request		Details \| Review

Martin Thomson [:mt:]

Reporter

Description

•

6 years ago

The tests we run on taskcluster for ssl.sh don't cover everything.  It's hard to understand the setup because there are so many interlocking options, but the most obvious omission is that NSS_SSL_TESTS is always set to "crl iopr policy".  This variable includes other options.  Of these, the combination of "normal" and "fips" modes for server and client are the most egregious omission.  That is because under these, the tests governed by NSS_SSL_RUN are run.  That's a lot of testing.

I don't think that we have to run all four combinations of "normal" and "fips".  We should only do that for the "Linux x64 fips" builds.

A big concern here is that the test suite takes a very long time to run.  I started a run before filing this bug, and it's been running for 20 minutes with no end in sight (yes, I'm slow at opening bugs).  It looks like the "stress" tests are taking a very long time.  If those are the only problem, we can probably drop them or separate those.  The work they do is very repetitive and is likely duplicative of the much faster gtests we have.

Kevin Jacobs [:kjacobs]

Assignee