14857 - replace 'ondblclick' with 'onmousedown' + event.clickCount == 2

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Chris Waterson]

sfraser: I heard a rumor that this problem occurring on Mac, as well. Is it
limited to the tree control?

Comment 1

[joki (gone)]

I recently fix the clickCount bug to conform with the DOM spec.  Basically this
means if you used to handle dblclick you should now handle mousedown with a
clickCount of 2.  I grepped through to find the spots where we used dblclick to
modify them to handle both cases (until all the widget libs are up to speed).
Did I miss a case?

Comment 2

[Simon Fraser [no longer active]]

Double clicking on rows in the tree works fine for me, especially since I fixed
the Mac event dispatching to do double-click detection properly. So I don't know
if there is any real problem here.

Comment 3

[Chris Waterson]

ok, cool, that was it. joki: did you grep through the JS & XUL files for
'ondblclick', as well?

Comment 4

[Chris Waterson]

joki: am I understanding this correctly? 'ondblclick' is now broken? If so, do
we need to fix all the following instances:

http://lxr.mozilla.org/seamonkey/search?string=ondblclick

...to use

  onmousedown="if (event.clickCount == 2) { /* do whatever ondblclick did
before */ }"

Or should 'ondblclick' still work?

Comment 5

[joki (gone)]

No, we should be replacing them.  I'm not sure about the ones in the activeX
control, I'll need to look more closely at that.  But the others should change.

Comment 6

[Chris Waterson]

oh this is evil. my 'mark and sweep' algorithm is breaking because of RDF
containers, which add assertions that are dependent on the current state of the
graph; e.g., RDF:nextVal.

So, for example, what happens is that you have an RDF container with two
elements in it. You refresh the file. The two elements stream in, and are added
as '3' and '4', instead of being recognized as the same '1' and '2' again.
Since '1' and '2' aren't marked, they get swept. Since sweeping happens after
assertion, the values disappear. UGh.

Comment 7

[Chris Waterson]

Oh damn. Ignore the previous comments. I added them to the wrong.

Comment 8

[Steve Lamm]

I applied the suggested fix to bookmarks, but it does not work. clickCount
reports either 1 or 3, but never 2 on linux. I have not tried windows yet.

Comment 9

[Steve Lamm]

clickCount works fine on Windows.

Comment 10

[Steve Lamm]

event.clickCount works on Linux now too, so I converted the bookmarks panel, the
related links panel, the bookmarks window, and the history window over to use
it.

Comment 11

[Chris Waterson]

I think rjc fixed this.

Comment 12

[Jan Carpenter]

marking verified per reporter comments.