1487035 - Port Bug 1469902 - Migrate <tabbox> to a Custom Element

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

After this landed, TB is completely busted, only a grey screen.

Debug console shows:
[6592, Main Thread] WARNING: Unable to locate an XBL binding for URI chrome://global/content/bindings/tabbox.xml#tabbox in document chrome://messenger/content/messenger.xul: file c:/mozilla-source/comm-central/dom/xbl/nsXBLService.cpp, line 783

Comment 1

[Geoff Lankow (:darktrojan)]

We have bindings that extend tabbox. Fun.

https://searchfox.org/comm-central/search?q=tabbox.xml

Comment 2

[Tim Nguyen :ntim]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1469902#c7 for possible solutions

Comment 3

[Richard Marti (:Paenglab)]

Attachment: tabbox.patch

Fix by restoring the tabbox binding. Maybe arshad can remove it and implement it in JS in a later patch.

Added two reviewers for whoever is faster.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9004819 [details] [diff] [review]
tabbox.patch

Thanks, works for me. As in bug 1486051, this looks more like a quick fix to get us going again.

Comment 5

[Magnus Melin [:mkmelin]]

Hmm, https://searchfox.org/comm-central/source/mail/base/content/messenger.xul#398 already has tabcontainer set.

I'm trying one thing out now

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1487035-tabbox-1.diff

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9004832 [details] [diff] [review]
1487035-tabbox-1.diff

Review of attachment 9004832 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, thx! r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f8389d3d22be
Port bug 1469902: Remove our extended <tabbox> binding. r=mkmelin