Port Bug 1469902 - Migrate <tabbox> to a Custom Element

RESOLVED FIXED in Thunderbird 63.0

Status

defect
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jorgk, Assigned: darktrojan)

Tracking

Thunderbird 63.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

After this landed, TB is completely busted, only a grey screen.

Debug console shows:
[6592, Main Thread] WARNING: Unable to locate an XBL binding for URI chrome://global/content/bindings/tabbox.xml#tabbox in document chrome://messenger/content/messenger.xul: file c:/mozilla-source/comm-central/dom/xbl/nsXBLService.cpp, line 783
Flags: needinfo?(richard.marti)
Flags: needinfo?(geoff)
We have bindings that extend tabbox. Fun.

https://searchfox.org/comm-central/search?q=tabbox.xml
Posted patch tabbox.patch (obsolete) — Splinter Review
Fix by restoring the tabbox binding. Maybe arshad can remove it and implement it in JS in a later patch.

Added two reviewers for whoever is faster.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9004819 - Flags: review?(jorgk)
Attachment #9004819 - Flags: review?(geoff)
Keywords: leave-open
Comment on attachment 9004819 [details] [diff] [review]
tabbox.patch

Thanks, works for me. As in bug 1486051, this looks more like a quick fix to get us going again.
Flags: needinfo?(geoff)
Attachment #9004819 - Flags: review?(jorgk) → review+
Hmm, https://searchfox.org/comm-central/source/mail/base/content/messenger.xul#398 already has tabcontainer set.

I'm trying one thing out now
Assignee: richard.marti → geoff
Attachment #9004832 - Flags: review?(jorgk)
Comment on attachment 9004832 [details] [diff] [review]
1487035-tabbox-1.diff

Review of attachment 9004832 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, thx! r=mkmelin
Attachment #9004832 - Flags: review?(jorgk) → review+
Attachment #9004819 - Attachment is obsolete: true
Attachment #9004819 - Flags: review?(geoff)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f8389d3d22be
Port bug 1469902: Remove our extended <tabbox> binding. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
You need to log in before you can comment on or make changes to this bug.