Closed Bug 1488138 Opened Last year Closed Last year

empty out thuderbird's removed-files.in (port bug 1392913 )

Categories

(Thunderbird :: Installer, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 64.0

People

(Reporter: mkmelin, Assigned: jorgk)

Details

Attachments

(1 file, 1 obsolete file)

Quoting a thunderbird-drivers mail from Nick:

"Longer term it would be good to empty out the mail removed-files.in. Firefox did that after the bz2/lzma watershed at ~56, following the logic that anyone with a really old version would have already had an update that cleaned up the old cruft. TB beta already has such a watershed, and one will need to be added for TB release."

This was bug 1392913 for firefox.
Summary: empty out thuderbird's removed-files.in (prot bug 13929139) → empty out thuderbird's removed-files.in (port bug 13929139)
Summary: empty out thuderbird's removed-files.in (port bug 13929139) → empty out thuderbird's removed-files.in (port bug 1392913 )
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9006055 - Flags: review?(mkmelin+mozilla)
Tom pointed out that the following needed to be kept, from
https://hg.mozilla.org/comm-central/rev/fb94780cd594#l1.12

# Remove unpacked lightning extension.
#ifdef NIGHTLY_BUILD
@DIR_RESOURCES@extensions/
@DIR_RESOURCES@extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/*
#else
@DIR_RESOURCES@distribution/
@DIR_RESOURCES@distribution/extensions/
@DIR_RESOURCES@distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/*
#endif
Attachment #9006055 - Attachment is obsolete: true
Attachment #9006055 - Flags: review?(mkmelin+mozilla)
Attachment #9006062 - Flags: review?(mozilla)
Comment on attachment 9006062 [details] [diff] [review]
1488138-kill-content-of-removed-files.patch (v2)

Review of attachment 9006062 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/installer/removed-files.in
@@ +11,5 @@
> +# When to use removed-files.in file to remove files and directories:
> +# * Files and directories located in the installation's "distribution/" and
> +#   "extensions/" directories that were added before Thunderbird 27. Files and
> +#   directories located in these directories were not included in the
> +#   application update file removals for a complete update prior to Thunderbird 27.

This bullet point seems out of date?
Attachment #9006062 - Flags: review?(mozilla) → review+
OK, I can remove it, but this is copied verbatim from FF:
# * Files and directories located in the installation's "distribution/" and
#   "extensions/" directories that were added before Firefox 27. Files and
#   directories located in these directories were not included in the
#   application update file removals for a complete update prior to Firefox 27.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cf4b74f3b01f
empty out Thuderbird's removed-files.in (following bug 1392913). r=tomprince
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 64.0
You need to log in before you can comment on or make changes to this bug.