1488138 - empty out thuderbird's removed-files.in (port bug 1392913 )

Status: RESOLVED FIXED

(Thunderbird :: Installer, enhancement)

Description

[Magnus Melin [:mkmelin]]

Quoting a thunderbird-drivers mail from Nick:

"Longer term it would be good to empty out the mail removed-files.in. Firefox did that after the bz2/lzma watershed at ~56, following the logic that anyone with a really old version would have already had an update that cleaned up the old cruft. TB beta already has such a watershed, and one will need to be added for TB release."

This was bug 1392913 for firefox.

Comment 1

[Tom Prince [:tomprince]]

This was also suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1392913#c7

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1488138-kill-content-of-removed-files.patch

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1488138-kill-content-of-removed-files.patch (v2)

Tom pointed out that the following needed to be kept, from
https://hg.mozilla.org/comm-central/rev/fb94780cd594#l1.12

# Remove unpacked lightning extension.
#ifdef NIGHTLY_BUILD
@DIR_RESOURCES@extensions/
@DIR_RESOURCES@extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/*
#else
@DIR_RESOURCES@distribution/
@DIR_RESOURCES@distribution/extensions/
@DIR_RESOURCES@distribution/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/*
#endif

Comment 4

[Tom Prince [:tomprince]]

Comment on attachment 9006062 [details] [diff] [review]
1488138-kill-content-of-removed-files.patch (v2)

Review of attachment 9006062 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/installer/removed-files.in
@@ +11,5 @@
> +# When to use removed-files.in file to remove files and directories:
> +# * Files and directories located in the installation's "distribution/" and
> +#   "extensions/" directories that were added before Thunderbird 27. Files and
> +#   directories located in these directories were not included in the
> +#   application update file removals for a complete update prior to Thunderbird 27.

This bullet point seems out of date?

Comment 5

[Jorg K (CEST = GMT+2)]

OK, I can remove it, but this is copied verbatim from FF:
# * Files and directories located in the installation's "distribution/" and
#   "extensions/" directories that were added before Firefox 27. Files and
#   directories located in these directories were not included in the
#   application update file removals for a complete update prior to Firefox 27.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cf4b74f3b01f
empty out Thuderbird's removed-files.in (following bug 1392913). r=tomprince

Comment 7

[Jorg K (CEST = GMT+2)]

TB 60.5 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/120a894821e640eb2cdb37f148de02658c951cdb