1490414 - Preemptively fix unified bustage in layout/generic

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Daniel Holbert [:dholbert]]

Previously: bug 1321387, bug 1468663, bug 1480212.

If I turn off unification in layout/generic (remove UNIFIED_ from its moz.build), I get two issues.



First issue, a build error:
========
../../../mozilla/layout/generic/nsVideoFrame.cpp:185:41: error: member access into incomplete type 'mozilla::dom::ShadowRoot'
    MOZ_ASSERT(mContent->GetShadowRoot()->IsUAWidget());
========
(There are many more instances of the same issue for other lines).


Second issue, a build warning:
========
../../dist/include/nsIContent.h:481:36: warning: inline function 'nsIContent::GetShadowRoot' is not defined [-Wundefined-inline]
  inline mozilla::dom::ShadowRoot* GetShadowRoot() const;
                                   ^
../../../mozilla/layout/generic/nsVideoFrame.cpp:182:17: note: used here
  if (mContent->GetShadowRoot()) {
                ^
========

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1490414: Add #includes to fix non-unified build bustage in layout/generic. r?TYLin

- We need nsIContentInlines.h to provide the (inline) nsIContent::GetShadowRoot definition.
- We need ShadowRoot.h to allow dereferencing of the pointer that GetShadowRoot() returns.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 9008138 [details]
Bug 1490414: Add #includes to fix non-unified build bustage in layout/generic. r?TYLin

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/125ea3ea601d
Add #includes to fix non-unified build bustage in layout/generic. r=TYLin

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/125ea3ea601d